feat(ui): add label filter sync with URL query params#14816
feat(ui): add label filter sync with URL query params#14816Joibel merged 2 commits intoargoproj:mainfrom
Conversation
Signed-off-by: puretension <[email protected]>
Signed-off-by: puretension <[email protected]>
eduardodbr
left a comment
There was a problem hiding this comment.
tested locally with success
|
Hi @eduardodbr, Thanks for approving! After implementing this fix, Duplicate patterns found:• workflows-list.tsx + workflow-template-list.tsx: Same useState + queryParams + localStorage logic Duplicated code pattern:Proposal:Would you be interested in a follow-up PR after this merges that extracts this • Eliminate code duplication Let me know what you think! |
|
Hey, I would really like to have this feature. Is there any way I can contribute so that it can be released? |
Joibel
left a comment
There was a problem hiding this comment.
LGTM, thanks for taking the time to do this.
Signed-off-by: puretension <[email protected]>
Signed-off-by: puretension <[email protected]>
Fixes #14807
Motivation
WorkflowTemplates UI silently ignores label query parameters (e.g.,
?label=key%3Dvalue) unlike Workflows list, breaking URL filtering and preventing custom UI links for filtered template views.Modifications
ref-recorded-video.mov
Verification
?label=key%3Dvaluenow properly filters WorkflowTemplatesDocumentation