fix(elbv2): boolean ALB attributes not reflected in CloudFormation when set to false#37307
Closed
syukawa-gh wants to merge 2 commits intoaws:mainfrom
Closed
fix(elbv2): boolean ALB attributes not reflected in CloudFormation when set to false#37307syukawa-gh wants to merge 2 commits intoaws:mainfrom
syukawa-gh wants to merge 2 commits intoaws:mainfrom
Conversation
…en set to false When boolean ALB properties like dropInvalidHeaderFields, preserveHostHeader, xAmznTlsVersionAndCipherSuiteHeaders, preserveXffClientPort, and wafFailOpen were explicitly set to false, they were omitted from the CloudFormation template because the code used truthy checks (if (props.x)) instead of undefined checks (if (props.x !== undefined)). This meant changing these properties from true to false would not update the ALB configuration. Now all boolean ALB attributes use !== undefined checks and emit both 'true' and 'false' values, consistent with how http2Enabled was already handled. Closes aws#36409
github-actions
bot
added
the
beginning-contributor
github-actions
bot
added
bug
aws-cdk-automation
previously requested changes
Mar 23, 2026
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
Contributor
Author
|
Closing in favor of #37485 (same change, updated version) |
Contributor
|
Comments on closed issues and PRs are hard for our team to see. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When boolean ALB properties like
dropInvalidHeaderFields,preserveHostHeader,xAmznTlsVersionAndCipherSuiteHeaders,preserveXffClientPort, andwafFailOpenwere explicitly set tofalse, they were omitted from the CloudFormation template. This is because the code used truthy checks (if (props.x)) instead of undefined checks (if (props.x !== undefined)), so changing these fromtruetofalsewould not update the ALB.All five boolean ALB attributes now use
!== undefinedchecks and emit bothtrueandfalsevalues, consistent with howhttp2Enabledwas already handled.Closes #36409