Skip to content

fix(elbv2): boolean ALB attributes not reflected in CloudFormation when set to false #37307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
syukawa-gh wants to merge 2 commits into from
Closed

fix(elbv2): boolean ALB attributes not reflected in CloudFormation when set to false #37307

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a9547e6
fix(elbv2): boolean ALB attributes not reflected in CloudFormation wh…
syukawa-dev Mar 23, 2026
6274334
test(elbv2): add integ test for ALB boolean attributes set to false
syukawa-dev Mar 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions packages/aws-cdk-lib/aws-elasticloadbalancingv2/lib/alb/application-load-balancer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,13 +228,13 @@ export class ApplicationLoadBalancer extends BaseLoadBalancer implements IApplic

if (props.http2Enabled !== undefined) { this.setAttribute('routing.http2.enabled', props.http2Enabled ? 'true' : 'false'); }
if (props.idleTimeout !== undefined) { this.setAttribute('idle_timeout.timeout_seconds', props.idleTimeout.toSeconds().toString()); }
if (props.dropInvalidHeaderFields) { this.setAttribute('routing.http.drop_invalid_header_fields.enabled', 'true'); }
if (props.dropInvalidHeaderFields !== undefined) { this.setAttribute('routing.http.drop_invalid_header_fields.enabled', props.dropInvalidHeaderFields ? 'true' : 'false'); }
if (props.desyncMitigationMode !== undefined) { this.setAttribute('routing.http.desync_mitigation_mode', props.desyncMitigationMode); }
if (props.preserveHostHeader) { this.setAttribute('routing.http.preserve_host_header.enabled', 'true'); }
if (props.xAmznTlsVersionAndCipherSuiteHeaders) { this.setAttribute('routing.http.x_amzn_tls_version_and_cipher_suite.enabled', 'true'); }
if (props.preserveXffClientPort) { this.setAttribute('routing.http.xff_client_port.enabled', 'true'); }
if (props.preserveHostHeader !== undefined) { this.setAttribute('routing.http.preserve_host_header.enabled', props.preserveHostHeader ? 'true' : 'false'); }
if (props.xAmznTlsVersionAndCipherSuiteHeaders !== undefined) { this.setAttribute('routing.http.x_amzn_tls_version_and_cipher_suite.enabled', props.xAmznTlsVersionAndCipherSuiteHeaders ? 'true' : 'false'); }
if (props.preserveXffClientPort !== undefined) { this.setAttribute('routing.http.xff_client_port.enabled', props.preserveXffClientPort ? 'true' : 'false'); }
if (props.xffHeaderProcessingMode !== undefined) { this.setAttribute('routing.http.xff_header_processing.mode', props.xffHeaderProcessingMode); }
if (props.wafFailOpen) { this.setAttribute('waf.fail_open.enabled', 'true'); }
if (props.wafFailOpen !== undefined) { this.setAttribute('waf.fail_open.enabled', props.wafFailOpen ? 'true' : 'false'); }
if (props.clientKeepAlive !== undefined) {
const clientKeepAliveInMillis = props.clientKeepAlive.toMilliseconds();
if (clientKeepAliveInMillis < 1000) {
Expand Down
42 changes: 42 additions & 0 deletions packages/aws-cdk-lib/aws-elasticloadbalancingv2/test/alb/load-balancer.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,48 @@ describe('tests', () => {
});
});

test('Boolean attributes explicitly set to false are included in CloudFormation', () => {
// GIVEN
const stack = new cdk.Stack();
const vpc = new ec2.Vpc(stack, 'Stack');

// WHEN
new elbv2.ApplicationLoadBalancer(stack, 'LB', {
vpc,
dropInvalidHeaderFields: false,
preserveHostHeader: false,
xAmznTlsVersionAndCipherSuiteHeaders: false,
preserveXffClientPort: false,
wafFailOpen: false,
});

// THEN
Template.fromStack(stack).hasResourceProperties('AWS::ElasticLoadBalancingV2::LoadBalancer', {
LoadBalancerAttributes: Match.arrayWith([
{
Key: 'routing.http.drop_invalid_header_fields.enabled',
Value: 'false',
},
{
Key: 'routing.http.preserve_host_header.enabled',
Value: 'false',
},
{
Key: 'routing.http.x_amzn_tls_version_and_cipher_suite.enabled',
Value: 'false',
},
{
Key: 'routing.http.xff_client_port.enabled',
Value: 'false',
},
{
Key: 'waf.fail_open.enabled',
Value: 'false',
},
]),
});
});

test.each([59, 604801])('throw error for invalid clientKeepAlive in seconds', (duration) => {
// GIVEN
const stack = new cdk.Stack();
Expand Down
Loading
⚡