fix(lambda-nodejs): use powershell for spawn steps on Windows#37412
Merged
mergify[bot] merged 6 commits intomainfrom Mar 30, 2026
Merged
fix(lambda-nodejs): use powershell for spawn steps on Windows#37412mergify[bot] merged 6 commits intomainfrom
mergify[bot] merged 6 commits intomainfrom
Conversation
On Windows with Node 22+, direct spawnSync of npx.cmd fails with EINVAL. This routes spawn steps through powershell.exe on win32, while keeping shell steps on cmd.exe unchanged. Closes #37387
github-actions
bot
added
bug
aws-cdk-automation
previously requested changes
Mar 30, 2026
Abogical
added
the
pr-linter/exempt-integ-test
rix0rrr
approved these changes
Mar 30, 2026
…awn steps
Use powershellEscape ('' for single quotes) instead of posixShellEscape
('\'' for single quotes) when routing spawn steps through PowerShell on
Windows. Also prepend the & call operator so PowerShell treats the first
quoted token as a command invocation rather than a string expression.
Abogical
changed the title
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Contributor
Merge Queue Status
This pull request spent 6 hours 53 minutes 27 seconds in the queue, including 45 minutes 17 seconds running CI. Required conditions to merge
|
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Contributor
|
Comments on closed issues and PRs are hard for our team to see. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Closes #37387
Reason for this change
CDK 2.245.0 introduced direct
spawnSyncfor local bundling (9bf4263). On Windows with Node 22+,spawnSync npx.cmdfails withEINVALbecause Node's spawn implementation on Windows cannot resolve.cmdshims through the direct spawn path.Description of changes
For
spawnsteps onwin32, route the command throughpowershell.exe -NoProfile -Commandinstead of calling the executable directly. Shell steps (cmd /c) remain unchanged.Description of how you validated changes
aws-lambda-nodejs\test\integ.compilations.tsandaws-lambda-nodejs\test\integ.function.tsLocal bundling on Windows uses powershell for spawn steps— verifies esbuild invocation goes through powershell with properly escaped argsLocal bundling on Windows uses cmd for shell steps— verifies shell hooks still usecmdwhile spawn steps use powershellChecklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license