Fix PIPIP overlap in chat pane#1674
Merged
dmceachernmsft merged 10 commits intomainfrom Mar 16, 2022
Merged
Conversation
dmceachernmsft
requested review from
JamesBurnside,
PorterNan,
alkwa-msft,
anjulgarg,
carocao-msft,
edwardlee-msft,
mgamis-msft,
prabhjot-msft and
prprabhu-ms
as code owners
dmceachernmsft
changed the title
prprabhu-ms
reviewed
Mar 16, 2022
anjulgarg
approved these changes
Mar 16, 2022
…m/Azure/communication-ui-library into dmceachernmsft/pipipChatThreadFix
Contributor
Contributor
Contributor
Contributor
|
I'll refrain from approving this PR since I contributed to it. |
Contributor
Contributor
carocao-msft
approved these changes
Mar 16, 2022
mgamis-msft
approved these changes
Mar 16, 2022
Contributor
Contributor
dmceachernmsft
added a commit
that referenced
this pull request
Mar 16, 2022
* increase the z-index of the pipip * Move zIndex manipulation closer * Change files * removed unused import * add missing jsdoc comment * move getPipStyles to a better file. Co-authored-by: Prathmesh Prabhu <82062616+prprabhu-ms@users.noreply.github.com>
dmceachernmsft
added a commit
that referenced
this pull request
Mar 17, 2022
* Fix PIPIP overlap in chat pane (#1674) * increase the z-index of the pipip * Move zIndex manipulation closer * Change files * removed unused import * add missing jsdoc comment * move getPipStyles to a better file. Co-authored-by: Prathmesh Prabhu <82062616+prprabhu-ms@users.noreply.github.com> * Update js bundle automation snapshots * Update js bundle automation snapshots * Update composite automation snapshots Co-authored-by: Prathmesh Prabhu <82062616+prprabhu-ms@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
increase the z-index of the PIPIP in the chat and people panes
Why
ensures that the PIPIP is above the items in the chat and people panes.
Before:
After:
https://skype.visualstudio.com/SPOOL/_workitems/edit/2791126
How Tested
Ran locally and visually inspected.