This repository was archived by the owner on May 17, 2018. It is now read-only.
initialize() method only supports the "models" parameter as an array#76
Merged
wyuenho merged 2 commits intobackbone-paginator:masterfrom May 1, 2013
Merged
initialize() method only supports the "models" parameter as an array#76wyuenho merged 2 commits intobackbone-paginator:masterfrom
wyuenho merged 2 commits intobackbone-paginator:masterfrom
Conversation
… corresponding test
Member
|
This isn't actually advertised or documented. In fact there isn't a test case that guarantees this behavior in Backbone. It's just a side effect that |
Member
There was a problem hiding this comment.
Change _.isArray to _isArray to help the minifier with name mangling.
wyuenho
added a commit
that referenced
this pull request
May 1, 2013
Support non-array elements in the constructor
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the initialize method, the "models" parameter is considered an array. The thing is, in a plain backbone collection, I can do something like:
and it will instantiate the collection with a single model in it.
But if I do this with a pageable collection, I get errors because an object is not expected.