Skip to content
This repository was archived by the owner on May 17, 2018. It is now read-only.

initialize() method only supports the "models" parameter as an array #76

Merged
wyuenho merged 2 commits into from
May 1, 2013
Merged

initialize() method only supports the "models" parameter as an array #76

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
43ba082
Added object to array conversion to initialize's models parameter and…
master-contributor May 1, 2013
93f05a3
Fix #76 used acronym _isArray instead of _.isArray
master-contributor May 1, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/backbone-pageable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,6 +303,8 @@
state.firstPage :
state.currentPage;

if (!_.isArray(models)) models = models ? [models] : [];
Copy link
Copy Markdown
Member

@wyuenho wyuenho May 1, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change _.isArray to _isArray to help the minifier with name mangling.


if (mode != "server" && state.totalRecords == null && !_isEmpty(models)) {
state.totalRecords = models.length;
}
Expand Down
8 changes: 8 additions & 0 deletions test/client-pageable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,14 @@ $(document).ready(function () {

var mods = models.slice();

col = new Backbone.PageableCollection(mods[0], {
mode: "client"
});

strictEqual(col.state.totalRecords, 1);
strictEqual(col.fullCollection.size(), 1);
strictEqual(col.fullCollection.at(0).get("name"), "a");

col = new Backbone.PageableCollection(mods, {
comparator: comparator,
state: {
Expand Down
⚡