test(math): add missing mod function tests and improve docs#1
Open
bejaratommy wants to merge 1 commit intomasterfrom
Open
test(math): add missing mod function tests and improve docs#1bejaratommy wants to merge 1 commit intomasterfrom
bejaratommy wants to merge 1 commit intomasterfrom
Conversation
The mod function was missing test coverage in numeric_test.go, even though it was documented in docs/math.md. Add tests covering basic modulo, even divisors, and equality cases. Also expand the mod documentation to show a concrete example and clarify argument ordering, which is non-obvious in piped template syntax. Fixes Masterminds#458 Signed-off-by: Tommy <tommy@bejarano.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes Masterminds#458 (in Masterminds/sprig).
The
modfunction had no test coverage innumeric_test.go, despite being documented and implemented. The test file skipped fromdiv/divfdirectly tomul/mulf, leavingmoduntested.Changes
numeric_test.go: AddTestModcovering:10 % 3 = 1)10 % 2 = 0)10 % 10 = 0)7 % 3 = 1)docs/math.md: Expand themodsection with a concrete example and a note on argument ordering, which is non-obvious in piped template syntax.Testing
Note:
TestRoundhas a pre-existing floating-point precision failure on the upstreammasterbranch unrelated to this change.