[CLOSED] Tab and modality fixes for the modal dialogs

[core-ai-bot]

Issue by TomMalbran
Friday Aug 09, 2013 at 05:03 GMT
Originally opened as adobe/brackets#4714

---

This request fixes the tab issue #4589 by refcusing the first/last input when we will tab outside the dialog.

And modal issue #4687, by handling the z-index of the dialogs and backdrops.

I also fixed several links missing the href attribute to make them tab-able and using space on those items to trigger the click event which was missing.

---

TomMalbran included the following code: https://github.com/adobe/brackets/pull/4714/commits

[core-ai-bot]

Comment by TomMalbran
Friday Aug 09, 2013 at 21:30 GMT

---

By the way, after doing this PR I did PR #4718, so I ended up changing the links in the strings twice. PR #4718 would also make the links tab-able without adding the additional href='#', so I think we should merge that one first and I'll remove all the unnecessary link changes here.

[core-ai-bot]

Comment by RaymondLim
Wednesday Aug 21, 2013 at 20:22 GMT

---

Done with second review. Just have some comments and ready to merge if you're not going to change anything.

[core-ai-bot]

Comment by RaymondLim
Thursday Aug 22, 2013 at 06:34 GMT

---

Merging now.