[CLOSED] Fix #5062: Update notification is no longer modal

[core-ai-bot]

Issue by TomMalbran
Friday Sep 06, 2013 at 01:03 GMT
Originally opened as adobe/brackets#5085

---

Fix for issue #5062.

• Changed to using JavaScript to only show the last modal backdrop, since it can't be properly done in CSS.
• Added a new focus on AppReady to resend the focus to the dialog, since it gets lost when the file is open after the dialog.

---

TomMalbran included the following code: https://github.com/adobe/brackets/pull/5085/commits

[core-ai-bot]

Comment by RaymondLim
Monday Sep 09, 2013 at 22:26 GMT

---

Done initial review. Everything looks good except the button-focusing logic in App ready.

[core-ai-bot]

Comment by TomMalbran
Tuesday Sep 10, 2013 at 23:48 GMT

---

@RaymondLim Done. Moved the first check for updates to be done on App ready.

[core-ai-bot]

Comment by njx
Friday Sep 13, 2013 at 01:36 GMT

---

Removing@RaymondLim since he's out for a few days and I think we should try to merge this soon. Will reassign in tomorrow's standup.

[core-ai-bot]

Comment by julianasuh
Friday Sep 13, 2013 at 17:22 GMT

---

Assign back to Raymond as he will be back on 9/17 from his PTO.

[core-ai-bot]

Comment by RaymondLim
Wednesday Sep 18, 2013 at 04:05 GMT

---

Looks good. Merging.