feat(CVEs): Adds the API endpoint to check CVEs availability for given snap

[bartaz]

Done

Adds an API endpoint to check if given snap has CVE data available.
If the user is allowed to see the CVE data (is Canonical publisher and has access to said snap), and there is CVE data available in the snap-cves repo, it should return true, otherwise it should error.

How to QA

• sign in
• assuming you have access to docker snap (https://snapcraft-io-5100.demos.haus/docker/listing)
• go to API endpoint for snap that has CVES: https://snapcraft-io-5100.demos.haus/api/snaps/cve/docker - it should return succecss true
• go to any other snap you have access to that doesn't have CVEs: https://snapcraft-io-5100.demos.haus/api/snaps/cve/firefox - should return error that CVEs data is not available, with 404 status code
• go to API endpoint for non-existent snap: https://snapcraft-io-5100.demos.haus/api/snaps/cve/blabla - should also return error with 404 status code

Testing

• This PR has tests
• No testing required (explain why):

Issue / Card

Fixes WD-20926

[webteam-app]

Demo

Jenkins

demos.haus

[Copilot]

Pull Request Overview

This pull request adds a new API endpoint to check for the availability of CVE data for a given snap. Key changes include:

• Adding a new URL rule for the CVE endpoint in the publisher snaps view.
• Implementing access checks and CVE data handling in the cve_views module.
• Introducing a new helper method in cve_helper and adding tests for these endpoints.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
webapp/publisher/snaps/views.py	Added URL rule for the new CVE endpoint.
webapp/publisher/cve/cve_views.py	Refactored CVE access control and implemented the has_cves endpoint.
webapp/publisher/cve/cve_helper.py	Added a static method to check for CVE data availability.
tests/publisher/cve/test_has_cve_api.py	Added endpoint tests, though test names reference "policies" instead of "cves".
tests/publisher/cve/test_has_cve.py	Added tests for CVE data helper behavior and expected NotFound exception on 404 cases.

Comments suppressed due to low confidence (1)

tests/publisher/cve/test_has_cve_api.py:41

• [nitpick] The test case name 'test_get_policies_for_canonical_user' is ambiguous for a CVE endpoint; renaming it to 'test_has_cves_for_canonical_user' would improve clarity regarding its intent.

def test_get_policies_for_canonical_user(

[M7mdisk]

LGTM

[Copilot]

Pull Request Overview

This pull request adds an API endpoint to verify if a snap has associated CVE data available, incorporating user access validation and proper error handling. Key changes include:

• Adding a new URL rule in publisher/snaps/views.py to expose the endpoint.
• Refactoring CVE access checks into a common helper function (can_user_access_cve_data) in cve_views.py and introducing the has_cve_data method in cve_helper.py.
• Updating and adding tests to ensure proper behavior for canonical and non-canonical users.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
webapp/publisher/snaps/views.py	Added URL rule for the new CVE data availability endpoint
webapp/publisher/cve/cve_views.py	Moved access checks to a new helper function and refactored views
webapp/publisher/cve/cve_helper.py	Introduced static method has_cve_data for verifying CVE data
tests/publisher/cve/test_has_cve_api.py	Added tests for the new API endpoint
tests/publisher/cve/test_has_cve.py	Added unit tests for the new CVE data checker method