Skip to content

Publisher pages lazy imports, pt2#5461

Merged
edisile merged 1 commit intopublisher-lazy-importfrom
publisher-lazy-import-2
Nov 19, 2025
Merged

Publisher pages lazy imports, pt2#5461
edisile merged 1 commit intopublisher-lazy-importfrom
publisher-lazy-import-2

Conversation

@edisile
Copy link
Copy Markdown
Contributor

@edisile edisile commented Nov 18, 2025

Done

  • lazy load snap Listing page component
  • lazy load snap Builds page component
  • lazy load snap Build details page component
  • lazy load snap Releases page component
  • lazy load snap Publicise page component
  • lazy load snap Settings page component

Due to how these pages are implemented (the breadcrumbs and tabs are rendered inside in each component rather than in a common layout) there will be an ugly redraw that will be addressed in another PR.

How to QA

  • visit the demo
  • log in
  • open the network tab in dev tools and filter by JS
  • visit the pages listed above in any order
    • the first time you will see a loading spinner
    • every page you visit will fetch at least one JS chunk
    • the second time the JS will be cached and there will be no loader

Testing

  • This PR has tests
  • No testing required (explain why):

@webteam-app
Copy link
Copy Markdown

@edisile edisile changed the title feature: lazy import snap management pages Publisher pages lazy imports, pt2 Nov 19, 2025
@edisile edisile merged commit 20b7cbe into publisher-lazy-import Nov 19, 2025
9 checks passed
@edisile edisile deleted the publisher-lazy-import-2 branch November 19, 2025 13:39
edisile added a commit that referenced this pull request Nov 25, 2025
* Publisher pages lazy imports, pt1 (#5460)

* feature: lazy Suspense wrapper component

* feature: lazy import AccountDetails

* fix: linting

* feature: importComponent test

* feature: lazy import snap management pages (#5461)

* Publisher pages lazy import, pt3 (#5465)

* chore: restructure snaps management pages layout

* feature: test SnapsManagementLayout

* chore: cleanup

* fix: old broken tests

* feature: better coverage for tabs and breadcrumbs

* fix: comments to explain TODO items

* Publisher pages lazy import, pt4 (#5471)

* feature: lazy import account snaps and name registration pages

* fix: use Link components for SPA navigation

* Publisher pages lazy import, pt5 (#5476)

* fix: use Link components for SPA navigation

* feature: lazy import models, model details and policies pages

* chore: refactor model page layout to fix ugly rerender

* fix: use default loader

* fix: bad useQuery key (fix #5452)

* fix: test that now fails

* Publisher pages lazy import, pt6 (#5477)

* feature: lazy load more brand store pages

* fix: ignore AbortError when using AbourController.abort()

* feature: lazy load validations sets and keys pages (#5478)

* fix: /admin page redirect
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants