Skip to content

Publisher pages lazy import, pt6#5477

Merged
edisile merged 2 commits intopublisher-lazy-importfrom
publisher-lazy-import-6
Nov 24, 2025
Merged

Publisher pages lazy import, pt6#5477
edisile merged 2 commits intopublisher-lazy-importfrom
publisher-lazy-import-6

Conversation

@edisile
Copy link
Copy Markdown
Contributor

@edisile edisile commented Nov 24, 2025

Done

  • lazy load for brand store snaps, signing keys, members and settings
  • driveby: replaced a few loaders

How to QA

  • log in
  • open network tab in browser dev tools and filter by JS resources
  • open a brand store
    • you should see a JS chunk, a loader, then the page will load
  • open the "signing keys" page
    • you should see a JS chunk, a loader, then the page will load
  • go to the "members" page
    • you should see a JS chunk, a loader, then the page will load
  • go to the "settings" page
    • you should see a JS chunk, a loader, then the page will load
  • go back to any of the pages you just visited
    • there should be no new JS chunks and no loaders

Testing

  • This PR has tests
  • No testing required (explain why):

Issue / Card

Fixes #

Screenshots

@webteam-app
Copy link
Copy Markdown

Copy link
Copy Markdown
Contributor

@steverydz steverydz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@edisile edisile merged commit a00876a into publisher-lazy-import Nov 24, 2025
9 checks passed
@edisile edisile deleted the publisher-lazy-import-6 branch November 24, 2025 13:28
edisile added a commit that referenced this pull request Nov 25, 2025
* Publisher pages lazy imports, pt1 (#5460)

* feature: lazy Suspense wrapper component

* feature: lazy import AccountDetails

* fix: linting

* feature: importComponent test

* feature: lazy import snap management pages (#5461)

* Publisher pages lazy import, pt3 (#5465)

* chore: restructure snaps management pages layout

* feature: test SnapsManagementLayout

* chore: cleanup

* fix: old broken tests

* feature: better coverage for tabs and breadcrumbs

* fix: comments to explain TODO items

* Publisher pages lazy import, pt4 (#5471)

* feature: lazy import account snaps and name registration pages

* fix: use Link components for SPA navigation

* Publisher pages lazy import, pt5 (#5476)

* fix: use Link components for SPA navigation

* feature: lazy import models, model details and policies pages

* chore: refactor model page layout to fix ugly rerender

* fix: use default loader

* fix: bad useQuery key (fix #5452)

* fix: test that now fails

* Publisher pages lazy import, pt6 (#5477)

* feature: lazy load more brand store pages

* fix: ignore AbortError when using AbourController.abort()

* feature: lazy load validations sets and keys pages (#5478)

* fix: /admin page redirect
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants