chore: java web-service example#233
Merged
mergify[bot] merged 12 commits intocdk8s-team:masterfrom Jun 29, 2020
Merged
Conversation
Signed-off-by: campionfellin <campionfellin@gmail.com>
eladb
suggested changes
Jun 11, 2020
Signed-off-by: campionfellin <campionfellin@gmail.com>
eladb
pushed a commit
to cdklabs/jsii-srcmak
that referenced
this pull request
Jun 16, 2020
None, but related to comments on this PR: cdk8s-team/cdk8s#233 (comment) *Description of changes:* Rather than putting imports into a deep folder structure with package name, they all fall under `src/main`. A `cdk8s` java project with multiple imports looks like: ``` imports/ src/ main/ java/ k8s/ mattermost/ resources/ k8s/ mattermost/ ``` Note: using [ncp](https://github.com/AvianFlu/ncp) because `fs-extra` doesn't have copy/merge functionality. With `fs.move` option `overwrite` as `true`, you only get the last import in your list of imports. With `overwrite` false, it fails because `imports/src/main/` already exists. We want to effectively merge the two imports into this folder. `ncp` seemed like the best option here for this. Tested by `yarn link`ing this with `cdk8s` and importing over there. Signed-off-by: campionfellin <campionfellin@gmail.com>
Signed-off-by: campionfellin <campionfellin@gmail.com>
eladb
suggested changes
Jun 17, 2020
Signed-off-by: campionfellin <campionfellin@gmail.com>
Signed-off-by: campionfellin <campionfellin@gmail.com>
eladb
reviewed
Jun 17, 2020
eladb
previously approved these changes
Jun 18, 2020
Contributor
|
Your pull request will be updated and merged automatically (do not update manually). |
Signed-off-by: campionfellin <campionfellin@gmail.com>
Contributor
Author
|
Hey, nice, seems like #224 is working! Going to do java |
Signed-off-by: campionfellin <campionfellin@gmail.com>
eladb
approved these changes
Jun 29, 2020
Contributor
|
Your pull request will be updated and merged automatically (do not update manually). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: campionfellin campionfellin@gmail.com
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license