fix: java output location moved to src/main#3
Merged
eladb merged 4 commits intocdklabs:masterfrom Jun 16, 2020
Merged
Conversation
Signed-off-by: campionfellin <campionfellin@gmail.com>
Signed-off-by: campionfellin <campionfellin@gmail.com>
Signed-off-by: campionfellin <campionfellin@gmail.com>
Signed-off-by: campionfellin <campionfellin@gmail.com>
eladb
approved these changes
Jun 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: campionfellin campionfellin@gmail.com
Issue #, if available:
None, but related to comments on this PR:
cdk8s-team/cdk8s#233 (comment)
Description of changes:
Rather than putting imports into a deep folder structure with package name, they all fall under
src/main. Acdk8sjava project with multiple imports looks like:Note: using ncp because
fs-extradoesn't have copy/merge functionality.With
fs.moveoptionoverwriteastrue, you only get the last import in your list of imports. Withoverwritefalse, it fails becauseimports/src/main/already exists. We want to effectively merge the two imports into this folder.ncpseemed like the best option here for this.Tested by
yarn linking this withcdk8sand importing over there.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.