feat(overmind-svelte): upgrade to Svelte 5, fix duplicate subscription bug#656
Open
ericsorenson wants to merge 4 commits intonextfrom
Open
feat(overmind-svelte): upgrade to Svelte 5, fix duplicate subscription bug#656ericsorenson wants to merge 4 commits intonextfrom
ericsorenson wants to merge 4 commits intonextfrom
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
Adjusts formatting and indentation in test files for readability and consistency. Changes include converting single-line expects and callbacks to multi-line, adding parentheses around arrow function params, and aligning object matchers. No behavioral or logic changes to tests; only stylistic edits in packages/overmind-svelte/src/index.test.ts and index.production.test.ts.
henri-hulski
approved these changes
Apr 19, 2026
Member
henri-hulski
left a comment
henri-hulski
left a comment
There was a problem hiding this comment.
Looks great! Good to have Svelte fixed :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade svelte 3→5 using legacy compatibility mode. Replace the deprecated track(callback)/stopTracking() API with track()/subscribe(), matching the pattern used in overmind-vue. The previous code called tree.subscribe() inside afterUpdate, which registered duplicate listeners on every component update. Now subscribe is called once immediately after the initial state read.
Update test tooling (svelte-jester 5, @testing-library/svelte 4) and rewrite tests to achieve 100% coverage.