Conversation
Member
Author
|
Regarding the What does this change NOT address? section: |
robdimsdale
approved these changes
Aug 29, 2022
brayanhenao
approved these changes
Aug 29, 2022
* There's no documentation that suggests that while installing from a remote url via a VCS like `hg`, the `mercurial` package should be pre-installed. [Pip documentation](https://pip.pypa.io/en/latest/topics/vcs-support/) just states that it requires a working executable to be available, which already exists on the stack. ``` ‣ docker run --init -it cloudfoundry/cflinuxfs3 bash -c "hg --version" Mercurial Distributed SCM (version 4.5.3) ``` * When `fixtures/mercurial` is built by this branch's buildpack, we can see in the log python-hglib (which was the package referred to in the testdata by hg clone url) is installed. ``` Successfully installed Flask-2.2.2 ... python-hglib-2.6.2+2.1e7a64588ab0 ... ``` * Git history suggests that pre-installing mercurial via `pip install mercurial` ([link](https://github.com/cloudfoundry/python-buildpack/blob/v1.7.58/src/python/supply/supply.go#L201-L215)) came into this buildpack from the original heroku buildpack fork. Heroku has since removed it. See heroku/heroku-buildpack-python#1111 * This change does not address why running an app with `mercurial` present in the `requirements.txt` fails with the error pointing to a non-existent include path to `Python.h` even after include location is set via CFLAGS in 028a7b6. See [CI log](https://buildpacks.ci.cf-app.com/teams/main/pipelines/python-buildpack/jobs/specs-edge-integration-develop/builds/1054#L62d6d57b:516). The timing of this failure appearing in CI suggests that it's related to the package using the new setuptools version as a transitive dependency. See #574 This has to be separately investigated.
This was referenced Nov 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Edited Fri 8/26 with more details
What does this change address?
a remote url via a VCS like
hg, themercurialpackage should bepre-installed. Pip documentation just states that it requires a working
executable to be available, which already exists on the stack.
fixtures/mercurialis built by this branch's buildpack,we can see in the log python-hglib (which was the package referred to in
the testdata by hg clone url) is installed.
pip install mercurial(link)came into this buildpack from the original heroku buildpack fork.
Heroku has since removed it. See Remove redundant Mercurial install step heroku/heroku-buildpack-python#1111
What does this change NOT address?
mercurialpresent inthe
requirements.txtfails with the error pointing to a non-existent include path toPython.heven after include location is set via CFLAGS in 028a7b6.See CI log. The timing of this failure appearing in CI suggests that it's related to the
package using the new setuptools version as a transitive dependency. See python3.8.12 - fatal error: Python.h: No such file or directory #574
This has to be separately investigated.