Add grpc connection closing error to allowlist#156729
Conversation
|
Thank you for contributing to CockroachDB. Please ensure you have followed the guidelines for creating a PR. Before a member of our team reviews your PR, I have some potential action items for you:
🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
6b31148 to
ca7fe49
Compare
|
Thank you for updating your pull request. Before a member of our team reviews your PR, I have some potential action items for you:
🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
ca7fe49 to
5e9925c
Compare
|
Thanks for your contribution! I updated the PR to included the necessary generated code changes and I'll merge it after CI is green. |
|
bors r+ |
|
Build failed: |
|
bors retry |
|
Based on the specified backports for this PR, I applied new labels to the following linked issue(s). Please adjust the labels as needed to match the branches actually affected by the issue(s), including adding any known older branches. Issue #156078: branch-release-25.4. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Fix TestChangefeedFlushesSinkToReleaseMemory test flake
Fixes #156078
The test was failing on grpc connection closing errors that weren't being ignored. Using
grpcutil.IsClosedConnection()to properly handle all connection closing scenarios including the specific "grpc: the client connection is closing" error.Changed:
pkg/ccl/changefeedccl/helpers_test.go: Usegrpcutil.IsClosedConnection()in error handling