Skip to content

Add grpc connection closing error to allowlist#156729

Merged
craig[bot] merged 1 commit into
cockroachdb:masterfrom
sanki92:fix-156078-changefeed-test-grpc-error
Nov 7, 2025
Merged

Add grpc connection closing error to allowlist#156729
craig[bot] merged 1 commit into
cockroachdb:masterfrom
sanki92:fix-156078-changefeed-test-grpc-error

Conversation

@sanki92

@sanki92 sanki92 commented Nov 2, 2025

Copy link
Copy Markdown
Contributor

Fix TestChangefeedFlushesSinkToReleaseMemory test flake

Fixes #156078

The test was failing on grpc connection closing errors that weren't being ignored. Using grpcutil.IsClosedConnection() to properly handle all connection closing scenarios including the specific "grpc: the client connection is closing" error.

Changed:

  • pkg/ccl/changefeedccl/helpers_test.go: Use grpcutil.IsClosedConnection() in error handling

@sanki92 sanki92 requested a review from a team as a code owner November 2, 2025 07:18
@sanki92 sanki92 requested review from andyyang890 and removed request for a team November 2, 2025 07:18
@blathers-crl

blathers-crl Bot commented Nov 2, 2025

Copy link
Copy Markdown

Thank you for contributing to CockroachDB. Please ensure you have followed the guidelines for creating a PR.

Before a member of our team reviews your PR, I have some potential action items for you:

  • Please ensure your git commit message contains a release note.
  • When CI has completed, please ensure no errors have appeared.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@blathers-crl blathers-crl Bot added the O-community Originated from the community label Nov 2, 2025
@cockroach-teamcity

Copy link
Copy Markdown
Member

This change is Reviewable

Comment thread pkg/ccl/changefeedccl/helpers_test.go Outdated
@sanki92 sanki92 force-pushed the fix-156078-changefeed-test-grpc-error branch from 6b31148 to ca7fe49 Compare November 5, 2025 12:13
@blathers-crl

blathers-crl Bot commented Nov 5, 2025

Copy link
Copy Markdown

Thank you for updating your pull request.

Before a member of our team reviews your PR, I have some potential action items for you:

  • Please ensure your git commit message contains a release note.
  • When CI has completed, please ensure no errors have appeared.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@andyyang890 andyyang890 force-pushed the fix-156078-changefeed-test-grpc-error branch from ca7fe49 to 5e9925c Compare November 6, 2025 20:16
@andyyang890

Copy link
Copy Markdown
Collaborator

Thanks for your contribution! I updated the PR to included the necessary generated code changes and I'll merge it after CI is green.

@andyyang890 andyyang890 added the backport-25.4.x Flags PRs that need to be backported to 25.4 label Nov 6, 2025
@andyyang890

Copy link
Copy Markdown
Collaborator

bors r+

@craig

craig Bot commented Nov 7, 2025

Copy link
Copy Markdown
Contributor

Build failed:

@andyyang890

Copy link
Copy Markdown
Collaborator

bors retry

@craig

craig Bot commented Nov 7, 2025

Copy link
Copy Markdown
Contributor

@craig craig Bot merged commit 2237dd8 into cockroachdb:master Nov 7, 2025
33 of 34 checks passed
@blathers-crl

blathers-crl Bot commented Nov 7, 2025

Copy link
Copy Markdown

Based on the specified backports for this PR, I applied new labels to the following linked issue(s). Please adjust the labels as needed to match the branches actually affected by the issue(s), including adding any known older branches.


Issue #156078: branch-release-25.4.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cdc Change Data Capture backport-25.4.x Flags PRs that need to be backported to 25.4 O-community Originated from the community v26.1.0-prerelease

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ccl/changefeedccl: TestChangefeedFlushesSinkToReleaseMemory failed

4 participants