release-25.4: Add grpc connection closing error to allowlist#157059
Merged
Conversation
blathers-crl
Bot
force-pushed
the
blathers/backport-release-25.4-156729
branch
from
1dfd97e to
12f9fad
Compare
blathers-crl
Bot
requested review from
KeithCh
and removed request for
a team
blathers-crl
Bot
added
blathers-backport
Member
|
This change is |
Author
|
Thanks for opening a backport. Before merging, please confirm that the change does not break backwards compatibility and otherwise complies with the backport policy. Include a brief release justification in the PR description explaining why the backport is appropriate. All backports must be reviewed by the TL for the owning area. While the stricter LTS policy does not yet apply, please exercise judgment and consider gating non-critical changes behind a disabled-by-default feature flag when appropriate. |
blathers-crl
Bot
added
backport
andyyang890
approved these changes
Nov 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #156729 on behalf of @sanki92.
Fix TestChangefeedFlushesSinkToReleaseMemory test flake
Fixes #156078
The test was failing on grpc connection closing errors that weren't being ignored. Using
grpcutil.IsClosedConnection()to properly handle all connection closing scenarios including the specific "grpc: the client connection is closing" error.Changed:
pkg/ccl/changefeedccl/helpers_test.go: Usegrpcutil.IsClosedConnection()in error handlingRelease justification: test-only change