Skip to content

Add option for changing ignoreBadDataPoints in GetExtractedRanges#646

Merged
ozangoktan merged 2 commits intomasterfrom
option-to-not-ignore-bad-datapoints-in-get-latest-earliest
Mar 23, 2026
Merged

Add option for changing ignoreBadDataPoints in GetExtractedRanges#646
ozangoktan merged 2 commits intomasterfrom
option-to-not-ignore-bad-datapoints-in-get-latest-earliest

Conversation

@ozangoktan
Copy link
Copy Markdown
Contributor

This should be something we can specify. Changes it to be so.

@ozangoktan ozangoktan requested a review from a team as a code owner March 23, 2026 10:32
Copy link
Copy Markdown

@nithinb nithinb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'll create a jira to sort of add tests for this functionality later

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.78%. Comparing base (c95d7f4) to head (78b036b).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #646      +/-   ##
==========================================
+ Coverage   77.69%   77.78%   +0.08%     
==========================================
  Files         136      136              
  Lines       13223    13226       +3     
  Branches     1991     1991              
==========================================
+ Hits        10274    10288      +14     
+ Misses       2114     2101      -13     
- Partials      835      837       +2     
Files with missing lines Coverage Δ
...gnite.Extensions/TimeSeries/DataPointExtensions.cs 82.62% <100.00%> (+0.03%) ⬆️
ExtractorUtils/Cognite/CogniteDestination.cs 78.43% <100.00%> (+0.12%) ⬆️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ozangoktan ozangoktan added the waiting-for-risk-review Waiting for a member of the risk review team to take an action label Mar 23, 2026
@ozangoktan
Copy link
Copy Markdown
Contributor Author

/gemini review

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces an option to ignore bad data points when fetching the earliest or latest timestamps for time series by adding an ignoreBadDataPoints parameter to GetLatestTimestamps, GetEarliestTimestamps, and GetExtractedRanges methods. The changes are propagated through CogniteDestination as well. While the implementation is correct, I've identified a potential issue regarding a change in the default behavior of these methods, which could be an unintended breaking change for existing users. Please see my comments for details.

@einarmo einarmo self-assigned this Mar 23, 2026
@einarmo einarmo added the risk-review-ongoing Risk review is in progress label Mar 23, 2026
@einarmo
Copy link
Copy Markdown
Contributor

einarmo commented Mar 23, 2026

🦄

@einarmo einarmo added waiting-for-team Waiting for the submitter or reviewer of the PR to take an action and removed waiting-for-risk-review Waiting for a member of the risk review team to take an action labels Mar 23, 2026
@ozangoktan ozangoktan merged commit f156431 into master Mar 23, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk-review-ongoing Risk review is in progress waiting-for-team Waiting for the submitter or reviewer of the PR to take an action

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants