Add option for changing ignoreBadDataPoints in GetExtractedRanges#646
Conversation
nithinb
left a comment
There was a problem hiding this comment.
LGTM. I'll create a jira to sort of add tests for this functionality later
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #646 +/- ##
==========================================
+ Coverage 77.69% 77.78% +0.08%
==========================================
Files 136 136
Lines 13223 13226 +3
Branches 1991 1991
==========================================
+ Hits 10274 10288 +14
+ Misses 2114 2101 -13
- Partials 835 837 +2
🚀 New features to boost your workflow:
|
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces an option to ignore bad data points when fetching the earliest or latest timestamps for time series by adding an ignoreBadDataPoints parameter to GetLatestTimestamps, GetEarliestTimestamps, and GetExtractedRanges methods. The changes are propagated through CogniteDestination as well. While the implementation is correct, I've identified a potential issue regarding a change in the default behavior of these methods, which could be an unintended breaking change for existing users. Please see my comments for details.
|
🦄 |
This should be something we can specify. Changes it to be so.