add Add integration test for GetExtractedRanges#654
Open
ozangoktan wants to merge 1 commit intomasterfrom
Open
add Add integration test for GetExtractedRanges#654ozangoktan wants to merge 1 commit intomasterfrom
ozangoktan wants to merge 1 commit intomasterfrom
Conversation
ozangoktan
force-pushed
the
integration-test-getextractedranges
branch
from
7f41a9f to
752a2a7
Compare
ozangoktan
force-pushed
the
integration-test-getextractedranges
branch
from
752a2a7 to
9a972ef
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #654 +/- ##
==========================================
+ Coverage 77.94% 77.97% +0.02%
==========================================
Files 136 136
Lines 13228 13228
Branches 1991 1991
==========================================
+ Hits 10311 10314 +3
+ Misses 2080 2077 -3
Partials 837 837 🚀 New features to boost your workflow:
|
Contributor
Author
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the 'CreateTestTimeSeries' helper method in the integration tests to support a dynamic number of time series and adds a new integration test, 'TestGetExtractedRanges'. This new test verifies the behavior of the 'GetExtractedRanges' method when handling data points with bad status codes, ensuring that the 'ignoreBadDataPoints' flag correctly filters or includes them. I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds an integration test for GetExtractedRanges which tests both ignoreBadDataPoints true and false behavior. Follow-up from #646