Add tests for logger to increase coverage#648
Merged
Conversation
Hmnt39
force-pushed
the
hemant/logger_coverage
branch
from
7fab6d6 to
f3875c1
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #648 +/- ##
==========================================
+ Coverage 77.94% 78.08% +0.13%
==========================================
Files 136 136
Lines 13228 13228
Branches 1991 1991
==========================================
+ Hits 10311 10329 +18
+ Misses 2080 2062 -18
Partials 837 837 🚀 New features to boost your workflow:
|
Contributor
Author
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces new unit tests for CallbackUtil and expands the LoggingTest suite to verify different logger configurations and levels. Feedback was provided regarding a potential IOException on Windows in the new logging tests, where the test.log file is deleted before the ServiceProvider is disposed, which may cause file lock conflicts.
Hmnt39
added
the
waiting-for-risk-review
ozangoktan
reviewed
Apr 1, 2026
Hmnt39
removed
the
waiting-for-risk-review
devendra-lohar
previously approved these changes
Apr 6, 2026
Hmnt39
added
the
waiting-for-risk-review
msusag
reviewed
Apr 8, 2026
msusag
added
waiting-for-team
|
@Hmnt39 , I added some questions related to the logfile name, please see #648 (comment) |
Hmnt39
added
waiting-for-risk-review
msusag
reviewed
Apr 8, 2026
msusag
added
waiting-for-team
Hmnt39
added
waiting-for-risk-review
devendra-lohar
previously approved these changes
Apr 9, 2026
|
🦄 |
msusag
added
waiting-for-team
devendra-lohar
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves test coverage for the logging and callback utilities by adding unit tests.