Skip to content

feat(client): add default key name#18101

Merged
tac0turtle merged 12 commits into
mainfrom
julien/default-from
Oct 16, 2023
Merged

feat(client): add default key name#18101
tac0turtle merged 12 commits into
mainfrom
julien/default-from

Conversation

@julienrbrt

Copy link
Copy Markdown
Contributor

Description

Closes: #17971

Allow to specify default --from key name in the config.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt requested a review from a team October 12, 2023 11:12
@ghost ghost requested review from a team, facundomedica and testinginprod and removed request for a team October 12, 2023 11:13
@github-actions

This comment has been minimized.

Comment thread x/staking/client/cli/tx.go
@julienrbrt julienrbrt requested a review from tac0turtle October 12, 2023 11:29
@tac0turtle tac0turtle added this pull request to the merge queue Oct 16, 2023
Merged via the queue into main with commit bb34c42 Oct 16, 2023
@tac0turtle tac0turtle deleted the julien/default-from branch October 16, 2023 11:10
@julienrbrt

Copy link
Copy Markdown
Contributor Author

I am going to leave this feature for v0.51 and improve confix to migrate client.toml as well for a better experience.

@julienrbrt

Copy link
Copy Markdown
Contributor Author

@Mergifyio backport release/v0.53.x

@mergify

mergify Bot commented Apr 1, 2025

Copy link
Copy Markdown
Contributor

backport release/v0.53.x

✅ Backports have been created

Details

mergify Bot pushed a commit that referenced this pull request Apr 1, 2025
(cherry picked from commit bb34c42)

# Conflicts:
#	CHANGELOG.md
#	client/config/config.go
#	client/context_test.go
#	client/tx/tx.go
#	client/v2/autocli/common.go
#	x/auth/client/cli/tx_sign.go
@julienrbrt

Copy link
Copy Markdown
Contributor Author

@Mergifyio backport main

@mergify

mergify Bot commented Apr 1, 2025

Copy link
Copy Markdown
Contributor

backport main

✅ Backports have been created

Details

mergify Bot pushed a commit that referenced this pull request Apr 1, 2025
(cherry picked from commit bb34c42)

# Conflicts:
#	CHANGELOG.md
#	client/config/config.go
#	client/context_test.go
#	client/tx/tx.go
#	client/v2/autocli/common.go
#	x/auth/client/cli/tx_sign.go
github-merge-queue Bot pushed a commit that referenced this pull request Apr 2, 2025
Co-authored-by: Julien Robert <julien@rbrt.fr>
Co-authored-by: Alex | Interchain Labs <alex@interchainlabs.io>
mergify Bot added a commit that referenced this pull request Apr 2, 2025
Co-authored-by: Julien Robert <julien@rbrt.fr>
Co-authored-by: Alex | Interchain Labs <alex@interchainlabs.io>
(cherry picked from commit 3ec128b)
beer-1 pushed a commit to initia-labs/cosmos-sdk that referenced this pull request Apr 4, 2025
…osmos#24332) (cosmos#24351)

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: Automatically set --from flag if one key in keyring

3 participants