Skip to content

refactor! : bump comet to v1 #19726

Merged
tac0turtle merged 56 commits into
mainfrom
marko/comet/v1
May 6, 2024
Merged

refactor! : bump comet to v1 #19726
tac0turtle merged 56 commits into
mainfrom
marko/comet/v1

Conversation

@tac0turtle

@tac0turtle tac0turtle commented Mar 12, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

This PR bumps comet to v1

changes:

  • remove validator pubkey/cryptoenc dependency from comet.
  • add consensus module params that are new to comet.
  • change abci methods inline with comet v1 changes
  • new api changes with genesis provider.

closes #20267

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

@coderabbitai

coderabbitai Bot commented Mar 12, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Important

Auto Review Skipped

More than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review.

64 files out of 157 files are above the max files limit of 50. Please upgrade to Pro plan to get higher limits.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@tac0turtle tac0turtle added the S:blocked Status: Blocked label Mar 12, 2024
tac0turtle
tac0turtle commented Apr 9, 2024
View reviewed changes
Comment thread api/cosmos/base/abci/v1beta1/abci.pulsar.go
Comment on lines -5 to -6
abci "buf.build/gen/go/tendermint/tendermint/protocolbuffers/go/tendermint/abci"
types "buf.build/gen/go/tendermint/tendermint/protocolbuffers/go/tendermint/types"

@tac0turtle tac0turtle Apr 9, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@julienrbrt any idea why this is happening?

@itsdevbear

itsdevbear commented May 6, 2024

Copy link
Copy Markdown

🤠

julienrbrt
julienrbrt approved these changes May 6, 2024
View reviewed changes

@julienrbrt julienrbrt left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! We should add a changelog linking this PR.
CI complains about mocks as well.

Comment thread testutil/network/util.go
@julienrbrt julienrbrt changed the title chore : bump comet to v1 refactor! : bump comet to v1 May 6, 2024
@kocubinski kocubinski self-assigned this May 6, 2024
@sonarqubecloud

sonarqubecloud Bot commented May 6, 2024

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed for 'cosmos-sdk-x-consensus'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@tac0turtle tac0turtle enabled auto-merge May 6, 2024 14:10
@tac0turtle tac0turtle added this pull request to the merge queue May 6, 2024
Merged via the queue into main with commit 0dfb54e May 6, 2024
@tac0turtle tac0turtle deleted the marko/comet/v1 branch May 6, 2024 14:16
@aljo242 aljo242 mentioned this pull request Feb 25, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@facundomedica facundomedica facundomedica approved these changes

@julienrbrt julienrbrt julienrbrt approved these changes

@samricotta samricotta samricotta approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@alpe alpe

@kocubinski kocubinski

@facundomedica facundomedica

@julienrbrt julienrbrt

@sontrinh16 sontrinh16

Labels

C:CLI C:Simulations C:Store C:x/auth C:x/authz C:x/bank C:x/consensus C:x/distribution distribution module related C:x/epochs C:x/evidence C:x/feegrant C:x/genutil genutil module issues C:x/gov C:x/group C:x/mint C:x/params C:x/protocolpool C:x/slashing C:x/staking C:x/upgrade Type: ADR Type: Build

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature/baseapp]: integrate comet v1

10 participants

@tac0turtle @itsdevbear @facundomedica @julienrbrt @samricotta @github-advanced-security @alpe @kocubinski @sontrinh16 @yihuang
⚡