chore: remove unused orm module (backport #23633)#23636
Conversation
(cherry picked from commit d7f101e) # Conflicts: # x/params/proto/buf.gen.pulsar.yaml # x/params/sonar-project.properties
|
Cherry-pick of d7f101e has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Description
Closes: #23635
On the
releases/v0.50.xbranch there is a failing test for the orm module. It looks like this module has not been in active development for some time, and is isolated into it's own module that was last released 2 years ago (https://github.com/cosmos/cosmos-sdk/tree/orm/v1.0.0-beta.3). The failing test was fixed on the main branch, but was not backported to thereleases/v0.50.x.Since the module is not in active development, and I am unaware of plans to continue development of the module, I recommend removing the module from the main branch, and backporting it to releases/v0.50.x.
Deleting orm from the Cosmos SDK repo is safe, even on the v0.50.x branch because it is isolated into it's own module, and the cosmos-sdk doesn't depend on it. So as far as cosmos-sdk releases are concerned the deletion of the module has no effect, and thus is non-breaking.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
included the correct type prefix in the PR title, you can find examples of the prefixes below:
confirmed
!in the type prefix if API or client breaking changetargeted the correct branch (see PR Targeting)
provided a link to the relevant issue or specification
reviewed "Files changed" and left comments if necessary
included the necessary unit and integration tests
added a changelog entry to
CHANGELOG.mdupdated the relevant documentation or specification, including comments for documenting Go code
confirmed all CI checks have passed
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.
I have...
This is an automatic backport of pull request #23633 done by [Mergify](https://mergify.com).