Skip to content

chore: remove unused orm module (backport #23633)#23636

Merged
aljo242 merged 1 commit into
release/v0.52.xfrom
mergify/bp/release/v0.52.x/pr-23633
Feb 7, 2025
Merged

chore: remove unused orm module (backport #23633)#23636
aljo242 merged 1 commit into
release/v0.52.xfrom
mergify/bp/release/v0.52.x/pr-23633

Conversation

@mergify

@mergify mergify Bot commented Feb 7, 2025

Copy link
Copy Markdown
Contributor

Description

Closes: #23635

On the releases/v0.50.x branch there is a failing test for the orm module. It looks like this module has not been in active development for some time, and is isolated into it's own module that was last released 2 years ago (https://github.com/cosmos/cosmos-sdk/tree/orm/v1.0.0-beta.3). The failing test was fixed on the main branch, but was not backported to the releases/v0.50.x.

Since the module is not in active development, and I am unaware of plans to continue development of the module, I recommend removing the module from the main branch, and backporting it to releases/v0.50.x.

Deleting orm from the Cosmos SDK repo is safe, even on the v0.50.x branch because it is isolated into it's own module, and the cosmos-sdk doesn't depend on it. So as far as cosmos-sdk releases are concerned the deletion of the module has no effect, and thus is non-breaking.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title, you can find examples of the prefixes below:

  • confirmed ! in the type prefix if API or client breaking change

  • targeted the correct branch (see PR Targeting)

  • provided a link to the relevant issue or specification

  • reviewed "Files changed" and left comments if necessary

  • included the necessary unit and integration tests

  • added a changelog entry to CHANGELOG.md

  • updated the relevant documentation or specification, including comments for documenting Go code

  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

This is an automatic backport of pull request #23633 done by [Mergify](https://mergify.com).

(cherry picked from commit d7f101e)

# Conflicts:
#	x/params/proto/buf.gen.pulsar.yaml
#	x/params/sonar-project.properties
@mergify mergify Bot added the conflicts label Feb 7, 2025
@mergify

mergify Bot commented Feb 7, 2025

Copy link
Copy Markdown
Contributor Author

Cherry-pick of d7f101e has failed:

On branch mergify/bp/release/v0.52.x/pr-23633
Your branch is up to date with 'origin/release/v0.52.x'.

You are currently cherry-picking commit d7f101e6a.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by them: x/params/proto/buf.gen.pulsar.yaml
	deleted by them: x/params/sonar-project.properties

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@coderabbitai

coderabbitai Bot commented Feb 7, 2025

Copy link
Copy Markdown
Contributor

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@aljo242 aljo242 merged commit ec6b8fb into release/v0.52.x Feb 7, 2025
@aljo242 aljo242 deleted the mergify/bp/release/v0.52.x/pr-23633 branch February 7, 2025 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants