chore: remove unused orm module by zrbecker · Pull Request #23633 · cosmos/cosmos-sdk

zrbecker · 2025-02-07T02:18:37Z

Description

On the releases/v0.50.x branch there is a failing test for the orm module. It looks like this module has not been in active development for some time, and is isolated into it's own module that was last released 2 years ago (https://github.com/cosmos/cosmos-sdk/tree/orm/v1.0.0-beta.3). The failing test was fixed on the main branch, but was not backported to the releases/v0.50.x.

Since the module is not in active development, and I am unaware of plans to continue development of the module, I recommend removing the module from the main branch, and backporting it to releases/v0.50.x.

Deleting orm from the Cosmos SDK repo is safe, even on the v0.50.x branch because it is isolated into it's own module, and the cosmos-sdk doesn't depend on it. So as far as cosmos-sdk releases are concerned the deletion of the module has no effect, and thus is non-breaking.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

included the correct type prefix in the PR title, you can find examples of the prefixes below:
confirmed ! in the type prefix if API or client breaking change
targeted the correct branch (see PR Targeting)
provided a link to the relevant issue or specification
reviewed "Files changed" and left comments if necessary
included the necessary unit and integration tests
added a changelog entry to CHANGELOG.md
updated the relevant documentation or specification, including comments for documenting Go code
confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.

I have...

confirmed the correct type prefix in the PR title
confirmed all author checklist items have been addressed
reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

coderabbitai · 2025-02-07T02:18:45Z

📝 Walkthrough

Walkthrough

This pull request removes a vast number of files and corresponding code segments related to the Cosmos SDK ORM module. Documentation, configuration files, code generation scripts, implementation files (including various codecs, key encoders, ORM backend and model logic), and nearly all tests have been deleted. No new functionality or modifications to exported public entities were introduced; rather, existing ORM-related implementations have been entirely removed.

Changes

File(s)	Change Summary
orm/CHANGELOG.md, orm/README.md, orm/go.mod, orm/internal/buf*.yaml	Removed ORM documentation, module dependency, and Buf configuration files.
orm/Makefile, orm/cmd/protoc-gen-go-cosmos-orm*/main.go	Deleted the codegen target and entry point files used for generating ORM protobuf code.
orm/encoding/ormfield/*	Eliminated numerous codec implementations (bool, bytes, enum, int32, int64, string, duration, timestamp, uint32, uint64) along with their test files.
orm/encoding/ormkv/*	Removed interfaces, types, and tests for key encoding/decoding and entry management in the ORM key-value module.
orm/internal/codegen/*	Deleted code generation scripts and configuration (file.go, index.go, query.go, singleton.go, table.go) used to produce ORM-related code.
orm/internal/testkv/*	Removed debugging utilities, LevelDB, and in-memory testing backends along with iterator wrappers.
orm/internal/testpb/*	Deleted test protobuf schemas, RPC service definitions, and banking ORM implementations with their tests.
orm/model/ormdb/, ormlist/, ormtable/*, orm/orm.go	Removed ORM model files covering database/table implementations, schema builders, genesis handlers, module initialization, and associated tests.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

tac0turtle · 2025-02-07T08:12:43Z

Just a heads up there are teams using this, this is why we couldn't remove it. Doing a GitHub search will tell you which users to reach out to.

Huge fan of the removal though

zrbecker · 2025-02-07T13:45:43Z

Just a heads up there are teams using this, this is why we couldn't remove it. Doing a GitHub search will tell you which users to reach out to.

Huge fan of the removal though

I did a GitHub search and saw users were using v1.0.0-beta.3 released two years ago.

I'm not planning on removing the tags that they are using, so removing it on SDK release branches will not break them.

If active development needs to pick up for this module, I recommend forking it into a repo where development can continue.

There does not seem a purpose to have an unmaintained module on the SDK release branches though.

(cherry picked from commit d7f101e) # Conflicts: # x/params/proto/buf.gen.pulsar.yaml # x/params/sonar-project.properties

(cherry picked from commit d7f101e) # Conflicts: # orm/CHANGELOG.md # orm/README.md # orm/encoding/encodeutil/util.go # orm/encoding/ormfield/bool.go # orm/encoding/ormfield/codec_test.go # orm/encoding/ormfield/duration.go # orm/encoding/ormfield/duration_test.go # orm/encoding/ormfield/enum.go # orm/encoding/ormfield/int32.go # orm/encoding/ormfield/int64.go # orm/encoding/ormfield/string.go # orm/encoding/ormfield/timestamp.go # orm/encoding/ormfield/timestamp_test.go # orm/encoding/ormfield/uint32.go # orm/encoding/ormfield/uint64.go # orm/encoding/ormkv/index_key.go # orm/encoding/ormkv/key_codec.go # orm/encoding/ormkv/primary_key.go # orm/encoding/ormkv/unique_key.go # orm/encoding/ormkv/unique_key_test.go # orm/go.mod # orm/go.sum # orm/internal/codegen/file.go # orm/internal/codegen/index.go # orm/internal/codegen/query.go # orm/internal/listinternal/options.go # orm/internal/testkv/compare.go # orm/internal/testkv/debug.go # orm/internal/testkv/leveldb.go # orm/internal/testkv/mem.go # orm/model/ormdb/genesis.go # orm/model/ormdb/module.go # orm/model/ormdb/module_test.go # orm/model/ormtable/auto_increment_test.go # orm/model/ormtable/backend.go # orm/model/ormtable/batch.go # orm/model/ormtable/bench_test.go # orm/model/ormtable/hooks.go # orm/model/ormtable/iterator.go # orm/model/ormtable/table_test.go # orm/orm.go # orm/sonar-project.properties # orm/testing/ormmocks/hooks.go # orm/testing/ormmocks/match.go # orm/types/kv/store.go # orm/types/ormerrors/errors.go

Co-authored-by: Zachary Becker <zrbecker@gmail.com>

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Zachary Becker <zrbecker@gmail.com>

aaronc · 2025-02-12T17:53:51Z

As the original author of the orm, agree it should be moved to a standalone repo if someone wants to make updates and has the bandwidth for it.

* build(deps): Bump github.com/cosmos/cosmos-db from 1.1.0 to 1.1.1 (cosmos#23030) * build(deps): Bump github.com/cosmos/ledger-cosmos-go from 0.13.3 to 0.14.0 (cosmos#23029) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * feat(x/tx): add an option to encode maps using amino json (backport cosmos#23539) (cosmos#23540) Co-authored-by: Julien Robert <julien@rbrt.fr> * feat(client/v2): add map support (backport cosmos#23544) (cosmos#23554) Co-authored-by: Julien Robert <julien@rbrt.fr> * docs(keyring): add keyctl docs (backport cosmos#23563) (cosmos#23566) Co-authored-by: Alessio Treglia <al@essio.dev> * docs: correct explanation on how to set custom signer via depinject (backport cosmos#23654) (cosmos#23663) Co-authored-by: Julien Robert <julien@rbrt.fr> * chore: remove unused orm module (backport cosmos#23633) (cosmos#23637) Co-authored-by: Zachary Becker <zrbecker@gmail.com> * Merge commit from fork * Prevent empty groups (cherry picked from commit 95090a0ec1f193104ba7d6d033a490d1515e54d8) * Handle inflight proposals (cherry picked from commit 855983471882068894ed7952b592ab3e61b464b9) * No empty group with simulations * Update changelog * Set release date * updates * Update RELEASE_NOTES.md * Update RELEASE_NOTES.md --------- Co-authored-by: Alex Peters <alpe@users.noreply.github.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * Mark v0.50.12-pio-1 in the changelog. --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Julien Robert <julien@rbrt.fr> Co-authored-by: Alessio Treglia <al@essio.dev> Co-authored-by: Zachary Becker <zrbecker@gmail.com>

* fix(crypto): error if incorrect ledger public key (backport cosmos#19691) (cosmos#19745) Co-authored-by: Rootul P <rootulp@gmail.com> Co-authored-by: sontrinh16 <trinhleson2000@gmail.com> * build(deps): Bump github.com/cometbft/cometbft from 0.38.5 to 0.38.6 (cosmos#19751) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * fix: align signer extraction adapter for mempool remove (backport cosmos#19759) (cosmos#19773) Co-authored-by: mmsqe <mavis@crypto.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> * fix(x/upgrade): Stop treating inline JSON as a URL (backport cosmos#19706) (cosmos#19767) Co-authored-by: Richard Gibson <richard.gibson@gmail.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> * fix(client/v2): fix comment parsing (backport cosmos#19377) (cosmos#19777) Co-authored-by: Julien Robert <julien@rbrt.fr> * build(deps): Bump github.com/cosmos/iavl from 1.0.1 to 1.1.1 in store (cosmos#19770) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Cool Developer <cool199966@outlook.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * chore(store): add release date (cosmos#19797) * build(deps): Bump github.com/cosmos/gogoproto from 1.4.11 to 1.4.12 (cosmos#19811) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * feat(x/gov): emit proposer address in submit proposal event (backport cosmos#19842) (cosmos#19844) Co-authored-by: Aryan Tikarya <akaladarshi@gmail.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * feat(x/gov): emit depositor in `proposal_deposit` event (backport cosmos#19853) (cosmos#19859) Co-authored-by: Kien <kien@notional.ventures> Co-authored-by: Julien Robert <julien@rbrt.fr> * reuse fromAddrString (minor cleanup) (cosmos#19881) * feat(client): replace `event-query-tx-for` with `wait-tx` (backport cosmos#19870) (cosmos#19887) * feat(server): add custom start handler (backport cosmos#19854) (cosmos#19884) Co-authored-by: Julien Robert <julien@rbrt.fr> * build(deps): Bump cosmossdk.io/store from 1.0.2 to 1.1.0 (cosmos#19810) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * docs(x/mint): Fix inconsistency in mint docs (backport cosmos#19915) (cosmos#19925) * build(deps): Bump github.com/cosmos/iavl from 1.1.1 to 1.1.2 (cosmos#19985) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * fix(client/v2): add encoder for `cosmos.base.v1beta1.DecCoin` (backport cosmos#19976) (cosmos#20001) Co-authored-by: Julien Robert <julien@rbrt.fr> * fix(mempool): use no-op mempool as default (backport cosmos#19970) (cosmos#20008) Co-authored-by: Tom <54514587+GAtom22@users.noreply.github.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * feat: Conditionally emit metrics based on enablement (backport cosmos#19903) (cosmos#20017) Co-authored-by: Lucas Francisco López <lucaslopezf@gmail.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * fix(x/bank): align query with multi denoms for send-enabled (backport cosmos#20028) (cosmos#20029) Co-authored-by: mmsqe <mavis@crypto.com> * fix: Implement gogoproto customtype to secp256r1 keys (backport cosmos#20027) (cosmos#20031) Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com> * fix(client/v2): respect output format from client ctx (backport cosmos#20033) (cosmos#20046) Co-authored-by: mmsqe <mavis@crypto.com> * build(deps): Bump cosmossdk.io/x/tx from 0.13.1 to 0.13.2 (cosmos#20042) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * feat(x/bank): support depinject for send restrictions (backport cosmos#20014) (cosmos#20024) * fix(baseapp): don't share global gas meter in tx execution (backport cosmos#19616) (cosmos#20050) * fix: secp256r1 json missing quotes (backport cosmos#20060) (cosmos#20069) Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com> * build(deps): Bump github.com/cosmos/cosmos-proto from 1.0.0-beta.4 to 1.0.0-beta.5 (cosmos#20095) * feat(client/v2): implement version filtering using annotation (backport cosmos#20083) (cosmos#20099) Co-authored-by: Julien Robert <julien@rbrt.fr> * chore: prepare v0.50.6 (cosmos#19998) * fix: use timestamp for sim log file name (backport cosmos#20108) (cosmos#20111) Co-authored-by: mmsqe <mavis@crypto.com> * fix(x/authz,x/feegrant): check blocked address (cosmos#20102) * chore: update v0.50.6 release notes (cosmos#20124) * build(deps): bump sdk in modules (cosmos#20126) * docs(gas/fees): Update block gas documentation (backport cosmos#20128) (cosmos#20131) Co-authored-by: samricotta <37125168+samricotta@users.noreply.github.com> * fix(baseapp): avoid header height overwrite block height (backport cosmos#20107) (cosmos#20129) Co-authored-by: mmsqe <mavis@crypto.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * docs: fix broken link (backport cosmos#20133) (cosmos#20138) * build(deps): bump modules in simapp (cosmos#20137) * build(deps): Bump cosmossdk.io/x/tx from 0.13.2 to 0.13.3 (cosmos#20152) * docs: add authz reference info in the circuit antehandler (backport cosmos#20146) (cosmos#20155) Co-authored-by: Reece Williams <31943163+Reecepbcups@users.noreply.github.com> * fix(testsuite/sims): set all signatures (backport cosmos#20151) (cosmos#20185) Co-authored-by: Leon <156270887+leonz789@users.noreply.github.com> * build(deps): Bump github.com/cometbft/cometbft from 0.38.6 to 0.38.7 (cosmos#20206) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * fix(server): bootstrap-state command can't parse latest genesis format (backport cosmos#20020) (cosmos#20045) Co-authored-by: yihuang <huang@crypto.com> Co-authored-by: Julien Robert <julien@rbrt.fr> Co-authored-by: sontrinh16 <trinhleson2000@gmail.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> * fix: remove txs from mempool when antehandler fails in recheck (backport cosmos#20144) (cosmos#20251) Co-authored-by: Marko <marko@baricevic.me> * feat(baseapp): expose grpc query router via depinject. (cosmos#20264) * feat(client/v2): override short description in generated command (backport cosmos#20266) (cosmos#20269) Co-authored-by: John Letey <j@letey.de> Co-authored-by: Julien Robert <julien@rbrt.fr> * feat(runtime): Add missing NewTransientStoreService (backport cosmos#20261) (cosmos#20327) Co-authored-by: beer-1 <147697694+beer-1@users.noreply.github.com> * fix: allow tx decoding to fail in GetBlockWithTxs (backport cosmos#20323) (cosmos#20329) Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> * fix(client/v2): correctly check subcommand short descriptions (backport cosmos#20330) (cosmos#20340) * build(deps): Bump cosmossdk.io/api from 0.7.4 to 0.7.5 (cosmos#20338) * style: Fix gov query proposals examples syntax (backport cosmos#20353) (cosmos#20357) * feat(client): add consensus address for debug cmd (backport cosmos#20328) (cosmos#20366) Co-authored-by: mmsqe <mavis@crypto.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * feat(client): overwrite client context instead of setting new one (backport cosmos#20356) (cosmos#20383) Co-authored-by: Shude Li <islishude@gmail.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * fix: correctly assign `execModeSimulate` to context for `simulateTx` (backport cosmos#20342) (cosmos#20346) Co-authored-by: Damian Nolan <damiannolan@gmail.com> Co-authored-by: Julien Robert <julien@rbrt.fr> Co-authored-by: marbar3778 <marbar3778@yahoo.com> * docs: update diagram to be shown properly (backport cosmos#20454) (cosmos#20460) Co-authored-by: tianyeyouyou <150894831+tianyeyouyou@users.noreply.github.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> * docs: fix note blocks display failure (backport cosmos#20457) (cosmos#20459) Co-authored-by: cocoyeal <150209682+cocoyeal@users.noreply.github.com> * docs: update link contents (backport cosmos#20437) (cosmos#20462) Co-authored-by: PolyMa <151764357+polymaer@users.noreply.github.com> * fix(x/consensus): harden consensus params proposal (cosmos#20381) Co-authored-by: Sergio Mena <sergio@informal.systems> Co-authored-by: sontrinh16 <trinhleson2000@gmail.com> * docs: add docs on permissions (backport cosmos#20526) (cosmos#20527) Co-authored-by: Marko <marko@baricevic.me> * chore(x/upgrade): bump vulnerable `go-getter` library (cosmos#20530) * chore: prepare v0.50.7 (cosmos#20475) * build(deps): Bump github.com/cosmos/gogoproto from 1.4.12 to 1.5.0 (cosmos#20567) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * refactor(x/authz,x/feegrant): provide updated keeper in depinject (cosmos#20590) * docs: Update high level overview and introduction (backport cosmos#20535) (cosmos#20627) Co-authored-by: samricotta <37125168+samricotta@users.noreply.github.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> * fix: Properly parse json in the wait-tx command. (backport cosmos#20631) (cosmos#20660) Co-authored-by: Daniel Wedul <github@wedul.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> * docs: remove Ineffective code block (backport cosmos#20703) (cosmos#20711) * feat(client): Add flag & reading mnemonic from file (backport cosmos#20690) (cosmos#20712) Co-authored-by: Hieu Vu <72878483+hieuvubk@users.noreply.github.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> * fix: nested multisig signatures using CLI (backport cosmos#20438) (cosmos#20692) Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> Co-authored-by: Facundo <facundomedica@gmail.com> * feat(client/v2): get keyring from context (backport cosmos#19646) (cosmos#20727) Co-authored-by: Julien Robert <julien@rbrt.fr> * docs(x/group): orm codespace comment (backport cosmos#20749) (cosmos#20751) * feat: parse home flag earlier (backport cosmos#20771) (cosmos#20777) Co-authored-by: Julien Robert <julien@rbrt.fr> * build(deps): Bump github.com/cometbft/cometbft from 0.38.7 to 0.38.8 (cosmos#20805) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * build(deps): Bump github.com/cometbft/cometbft from 0.38.8 to 0.38.9 (cosmos#20836) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * fix(simulation): fix the problem of `validator set is empty after InitGenesis` in simulation test (backport cosmos#18196) (cosmos#20897) Co-authored-by: Chenqun Lu <luchenqun@qq.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * fix(simulation): Fix all problems `make test-sim-custom-genesis-fast` for simulation test. (backport cosmos#17911) (cosmos#20909) Co-authored-by: Chenqun Lu <luchenqun@qq.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * chore: prepare v0.50.8 (cosmos#20910) * chore(simapp): use tagged version (cosmos#20951) * fix: include pagination.key at reverse mode (backport cosmos#20939) (cosmos#20954) Co-authored-by: beer-1 <147697694+beer-1@users.noreply.github.com> Co-authored-by: Facundo <facundomedica@gmail.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * build(deps): Bump github.com/cometbft/cometbft from 0.38.9 to 0.38.10 (cosmos#20960) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * fix(client/v2): use (PREFIX)_HOME instead of NODE_HOME (backport cosmos#20964) (cosmos#20970) Co-authored-by: Julien Robert <julien@rbrt.fr> * fix(client/grpc): `node.NewQueryServer` method not setting `cfg` (backport cosmos#20969) (cosmos#20973) * fix: NewIntegrationApp does not write default genesis to state (backport cosmos#21006) (cosmos#21008) Co-authored-by: son trinh <trinhleson2000@gmail.com> * fix(crypto): revert cosmos#20438 (cosmos#21019) * feat: use depinject v1.0.0 (cosmos#21000) * fix(runtime): remove `appv1alpha1.Config` from runtime (backport cosmos#21042) (cosmos#21080) Co-authored-by: Julien Robert <julien@rbrt.fr> Co-authored-by: marbar3778 <marbar3778@yahoo.com> * feat: check latest block if no arg in `q block` and `q block-results` (backport cosmos#21084) (cosmos#21111) Co-authored-by: Julien Robert <julien@rbrt.fr> Co-authored-by: sontrinh16 <trinhleson2000@gmail.com> * fix(simapp): concurrent map writes when calling GetSigners (backport cosmos#21073) (cosmos#21130) Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com> Co-authored-by: Julien Robert <julien@rbrt.fr> Co-authored-by: Facundo <facundomedica@gmail.com> * docs: Fix cli usage examples (backport cosmos#21150) (cosmos#21154) Co-authored-by: Christoph Otter <chipshort@tutanota.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * chore: bring in v0.13.x x/tx in release/v0.50.x (cosmos#21158) * build(deps): Bump cosmossdk.io/x/tx from 0.13.3 to 0.13.4 (cosmos#21170) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * fix(baseapp): return events from preblocker in FinalizeBlockResponse (backport cosmos#21159) (cosmos#21162) Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> Co-authored-by: Facundo <facundomedica@gmail.com> * chore: prepare v0.50.9 (cosmos#21163) * ci: attempt to fix goreleaser (backport cosmos#21194) (cosmos#21196) Co-authored-by: Julien Robert <julien@rbrt.fr> * build(deps): Bump cosmossdk.io/log from 1.3.1 to 1.4.0 (cosmos#21209) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * chore: backport NewMemStoreService method (cosmos#21212) * build(deps): Bump github.com/cosmos/gogoproto from 1.5.0 to 1.6.0 (cosmos#21234) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * feat: module hash by height query (backport cosmos#20779) (cosmos#21247) Co-authored-by: Adam Tucker <adam@osmosis.team> Co-authored-by: marbar3778 <marbar3778@yahoo.com> * build(deps): Bump github.com/cometbft/cometbft from 0.38.10 to 0.38.11 (cosmos#21264) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * feat(confix): allow customization of migration plan (backport cosmos#21202) (cosmos#21268) Co-authored-by: Tom <54514587+GAtom22@users.noreply.github.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * build(deps): Bump github.com/cosmos/gogoproto from 1.6.0 to 1.7.0 (cosmos#21294) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * fix(baseapp)!: Halt at height now does not produce the halt height block (backport cosmos#21256) (cosmos#21323) Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com> Co-authored-by: Facundo <facundomedica@gmail.com> * chore: bring in core v0.11.x (v0.50 compatible) to v0.50 (cosmos#21298) * docs: rename app v2 to app di when talking about runtime v0 (backport cosmos#21329) (cosmos#21335) Co-authored-by: Julien Robert <julien@rbrt.fr> * build(deps): Bump cosmossdk.io/log from 1.4.0 to 1.4.1 (cosmos#21351) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * docs: fix outdated link (backport cosmos#21397) (cosmos#21400) Co-authored-by: KI <KIVIKY@protonmail.com> * feat(x/bank): add origin address in event multisend (backport cosmos#21460) (cosmos#21465) Co-authored-by: Julien Robert <julien@rbrt.fr> * build(deps): Bump github.com/cosmos/ics23/go from 0.10.0 to 0.11.0 (cosmos#21473) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * fix(baseapp): preblock events are not emmitted correctly (backport cosmos#21444) (cosmos#21458) Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * fix(x/consensus)!: update cons params parsing checks (backport cosmos#21484) (cosmos#21493) Co-authored-by: MSalopek <matija.salopek994@gmail.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * fix(types/mempool): fix slice init length (backport cosmos#21494) (cosmos#21519) Co-authored-by: dropbigfish <fillfish@foxmail.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * build(deps): Bump github.com/cometbft/cometbft from 0.38.11 to 0.38.12 (cosmos#21535) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * feat(x/genutil): bulk add genesis accounts (backport cosmos#21372) (cosmos#21544) Co-authored-by: Reece Williams <31943163+Reecepbcups@users.noreply.github.com> Co-authored-by: Reece Williams <reecepbcups@gmail.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * fix(mempool): data race in mempool prepare proposal handler (backport cosmos#21413) (cosmos#21541) Co-authored-by: yihuang <huang@crypto.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * build(deps): bump iavl in cosmossdk.io/store 1.1.x (cosmos#21574) * docs(x/evidence): fix evidence module subcommands help message (backport cosmos#21589) (cosmos#21592) * docs(client/debug): correct and improve `debug pubkey-raw` command example (backport cosmos#21594) (cosmos#21600) Co-authored-by: lilasxie <thanklilas@163.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * docs(client/debug): correct `debug raw-bytes` command example (backport cosmos#21671) (cosmos#21676) Co-authored-by: lilasxie <thanklilas@163.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * docs(x/authz): update grant docs (backport cosmos#21677) (cosmos#21700) Co-authored-by: Eric Mokaya <4112301+ziscky@users.noreply.github.com> Co-authored-by: Akhil Kumar P <36399231+akhilkumarpilli@users.noreply.github.com> * feat(x/genutil): add better error messages for genesis validation (backport cosmos#21701) (cosmos#21708) Co-authored-by: Eric Mokaya <4112301+ziscky@users.noreply.github.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> * feat(types/collections): add `LegacyDec` collection value (backport cosmos#21693) (cosmos#21724) Co-authored-by: John Letey <john@noble.xyz> Co-authored-by: sontrinh16 <trinhleson2000@gmail.com> * docs: demonstrate how to wire custom ante handlers in 0.50 app_di (cosmos#21767) * docs(x/circuit): display correct example (backport cosmos#21768) (cosmos#21773) Co-authored-by: Julien Robert <julien@rbrt.fr> * fix(runtime): fix option order (backport cosmos#21769) (cosmos#21771) Co-authored-by: Julien Robert <julien@rbrt.fr> * chore: prepare v0.50.10 (cosmos#21498) * feat(x/tx): add `aminoNameAsTypeURL` option in aminojson encoder (backport cosmos#21712) (cosmos#21798) Co-authored-by: Julien Robert <julien@rbrt.fr> * feat(client/v2): use x/tx `AminoNameAsTypeURL` option in 0.50 (cosmos#21801) * feat(testutil/integration): allow to pass baseapp options (backport cosmos#21816) (cosmos#21818) Co-authored-by: Julien Robert <julien@rbrt.fr> Co-authored-by: marbar3778 <marbar3778@yahoo.com> * chore: correct date cl v0.50.10 (cosmos#21832) * feat(crypto/keyring): add Linux's keyctl support (backport cosmos#21653) (cosmos#21840) Co-authored-by: Alessio Treglia <al@essio.dev> Co-authored-by: marbar3778 <marbar3778@yahoo.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * fix(x/staking): query redelegation command (backport cosmos#21856) (cosmos#21861) Co-authored-by: Akhil Kumar P <36399231+akhilkumarpilli@users.noreply.github.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * chore(docs): rename merlin to simapp (backport cosmos#21884) (cosmos#21886) Co-authored-by: Marko <marko@baricevic.me> Co-authored-by: marbar3778 <marbar3778@yahoo.com> * fix(cli): avoid id isn't supported error when query address-by-acc-num (backport cosmos#21919) (cosmos#21922) Co-authored-by: mmsqe <mavis@crypto.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * fix(sims): Skip sims test when running dry on validators (backport cosmos#21906) (cosmos#21910) Co-authored-by: Alexander Peters <alpe@users.noreply.github.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * fix(client/v2): correctly handle enhanced sub commands (backport cosmos#21809) (cosmos#21930) Co-authored-by: John Letey <john@noble.xyz> Co-authored-by: Julien Robert <julien@rbrt.fr> * feat(client/v2): improve error message on enums (backport cosmos#21936) (cosmos#21938) Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * chore: regenerate addrbook.json for in-place-testnet (backport cosmos#21941) (cosmos#21947) Co-authored-by: Adam Tucker <adam@osmosis.team> Co-authored-by: Julien Robert <julien@rbrt.fr> * docs: update gov docs (backport cosmos#22048) (cosmos#22050) * docs(keys): remove unsupported `--dry-run` flag description for `keys migrate` (backport cosmos#22057) (cosmos#22070) Co-authored-by: tutufen <tutufen@outlook.com> * chore: Revert "docs: update gov docs (backport cosmos#22048)" (cosmos#22064) * docs(x/genutil): fix `genesis migrate` command examples (backport cosmos#22090) (cosmos#22097) Co-authored-by: tutufen <tutufen@outlook.com> * chore(simapp): be consistent with runtime (cosmos#22203) * docs: add docs boilerplate (backport cosmos#22202) (cosmos#22210) Co-authored-by: Julien Robert <julien@rbrt.fr> * fix(x/tx): sort with oneof field name in amino-json (backport cosmos#21782) (cosmos#22228) Co-authored-by: Luis Carvalho <mail.lmcarvalho@gmail.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * chore(x/group): update supported flags (backport cosmos#22229) (cosmos#22231) Co-authored-by: Julien Robert <julien@rbrt.fr> * fix(x/group): proper address rendering in error (backport cosmos#22425) (cosmos#22432) Co-authored-by: Julien Robert <julien@rbrt.fr> * feat(client/v2): add keyring flags in query commands (backport cosmos#22443) (cosmos#22445) Co-authored-by: Julien Robert <julien@rbrt.fr> * build(deps): Bump cosmossdk.io/depinject from 1.0.0 to 1.1.0 (cosmos#22463) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: sontrinh16 <trinhleson2000@gmail.com> * build(deps): Bump actions/xxx-artifact from v3 to v4 (cosmos#22473) * fix(server): fix fallback genesis path (backport cosmos#22564) (cosmos#22573) Co-authored-by: Julien Robert <julien@rbrt.fr> * build(deps): Bump cosmossdk.io/math from 1.3.0 to 1.4.0 (cosmos#22607) * fix(client/v2/autocli): prevent duplicate addition of customCommands (backport cosmos#22576) (cosmos#22615) Co-authored-by: violet <158512193+fastfadingviolets@users.noreply.github.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * build(deps): Bump github.com/cosmos/cosmos-db from 1.0.2 to 1.1.0 (cosmos#22638) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * build(deps): Bump github.com/cosmos/iavl from 1.2.0 to 1.2.2 (cosmos#22662) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * chore: prepare v0.50.11 (cosmos#22643) * fix(client/v2/autocli): add CoinDec flag (backport cosmos#22817) (cosmos#22821) Co-authored-by: Julián Toledano <JulianToledano@users.noreply.github.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * fix(x/tx): fix amino json drift from legacy spec (backport cosmos#21825) (cosmos#22088) * build(deps): Bump cosmossdk.io/x/tx from 0.13.6-0.20241003112805-ff8789a02871 to 0.13.6 (cosmos#22844) Co-authored-by: Julien Robert <julien@rbrt.fr> * chore: edit changelog store (partial backport cosmos#22864) (cosmos#22884) Co-authored-by: Julien Robert <julien@rbrt.fr> * Merge commit from fork * Limit recursion depth for unknown field detection (cherry picked from commit f038dc731c55be1e1c526e67695acc358631afd6) * Limit unpack any (cherry picked from commit 1a2bff56fb7391f9ce87d4fbe9e0367ae991c0b2) * Update Changelog * Another limit recursion depth for unknown field detection * Update changelog * chore: prep v0.50.11 release notes (cosmos#22898) * build(deps): Bump github.com/cosmos/cosmos-db from 1.1.0 to 1.1.1 (cosmos#23030) * build(deps): Bump github.com/cosmos/ledger-cosmos-go from 0.13.3 to 0.14.0 (cosmos#23029) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * feat(x/tx): add an option to encode maps using amino json (backport cosmos#23539) (cosmos#23540) Co-authored-by: Julien Robert <julien@rbrt.fr> * feat(client/v2): add map support (backport cosmos#23544) (cosmos#23554) Co-authored-by: Julien Robert <julien@rbrt.fr> * docs(keyring): add keyctl docs (backport cosmos#23563) (cosmos#23566) Co-authored-by: Alessio Treglia <al@essio.dev> * docs: correct explanation on how to set custom signer via depinject (backport cosmos#23654) (cosmos#23663) Co-authored-by: Julien Robert <julien@rbrt.fr> * chore: remove unused orm module (backport cosmos#23633) (cosmos#23637) Co-authored-by: Zachary Becker <zrbecker@gmail.com> * Merge commit from fork * Prevent empty groups (cherry picked from commit 95090a0ec1f193104ba7d6d033a490d1515e54d8) * Handle inflight proposals (cherry picked from commit 855983471882068894ed7952b592ab3e61b464b9) * No empty group with simulations * Update changelog * Set release date * updates * Update RELEASE_NOTES.md * Update RELEASE_NOTES.md --------- Co-authored-by: Alex Peters <alpe@users.noreply.github.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * feat: v0.50.12 * fix: go.mod * fix: distribution module BeginBlocker pointer regression * Merge commit from fork * Fix ABS061 * Use typed event * Add changelog * Review feedback * Check for events * Review feedback * Remove unecessary code comments * Set release date * fix changelog --------- Co-authored-by: Alex | Interchain Labs <alex@interchainlabs.io> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Rootul P <rootulp@gmail.com> Co-authored-by: sontrinh16 <trinhleson2000@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: mmsqe <mavis@crypto.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> Co-authored-by: Richard Gibson <richard.gibson@gmail.com> Co-authored-by: Julien Robert <julien@rbrt.fr> Co-authored-by: Cool Developer <cool199966@outlook.com> Co-authored-by: Aryan Tikarya <akaladarshi@gmail.com> Co-authored-by: Kien <kien@notional.ventures> Co-authored-by: yihuang <huang@crypto.com> Co-authored-by: Tom <54514587+GAtom22@users.noreply.github.com> Co-authored-by: Lucas Francisco López <lucaslopezf@gmail.com> Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com> Co-authored-by: samricotta <37125168+samricotta@users.noreply.github.com> Co-authored-by: Reece Williams <31943163+Reecepbcups@users.noreply.github.com> Co-authored-by: Leon <156270887+leonz789@users.noreply.github.com> Co-authored-by: Marko <marko@baricevic.me> Co-authored-by: John Letey <j@letey.de> Co-authored-by: beer-1 <147697694+beer-1@users.noreply.github.com> Co-authored-by: Shude Li <islishude@gmail.com> Co-authored-by: Damian Nolan <damiannolan@gmail.com> Co-authored-by: tianyeyouyou <150894831+tianyeyouyou@users.noreply.github.com> Co-authored-by: cocoyeal <150209682+cocoyeal@users.noreply.github.com> Co-authored-by: PolyMa <151764357+polymaer@users.noreply.github.com> Co-authored-by: Sergio Mena <sergio@informal.systems> Co-authored-by: Daniel Wedul <github@wedul.com> Co-authored-by: Hieu Vu <72878483+hieuvubk@users.noreply.github.com> Co-authored-by: Facundo <facundomedica@gmail.com> Co-authored-by: Chenqun Lu <luchenqun@qq.com> Co-authored-by: Christoph Otter <chipshort@tutanota.com> Co-authored-by: Adam Tucker <adam@osmosis.team> Co-authored-by: KI <KIVIKY@protonmail.com> Co-authored-by: MSalopek <matija.salopek994@gmail.com> Co-authored-by: dropbigfish <fillfish@foxmail.com> Co-authored-by: Reece Williams <reecepbcups@gmail.com> Co-authored-by: lilasxie <thanklilas@163.com> Co-authored-by: Eric Mokaya <4112301+ziscky@users.noreply.github.com> Co-authored-by: Akhil Kumar P <36399231+akhilkumarpilli@users.noreply.github.com> Co-authored-by: John Letey <john@noble.xyz> Co-authored-by: Alessio Treglia <al@essio.dev> Co-authored-by: Alexander Peters <alpe@users.noreply.github.com> Co-authored-by: tutufen <tutufen@outlook.com> Co-authored-by: Luis Carvalho <mail.lmcarvalho@gmail.com> Co-authored-by: auricom <27022259+auricom@users.noreply.github.com> Co-authored-by: violet <158512193+fastfadingviolets@users.noreply.github.com> Co-authored-by: Julián Toledano <JulianToledano@users.noreply.github.com> Co-authored-by: Zachary Becker <zrbecker@gmail.com> Co-authored-by: Alex | Interchain Labs <alex@interchainlabs.io>

* build(deps): Bump github.com/cosmos/cosmos-db from 1.1.0 to 1.1.1 (cosmos#23030) * build(deps): Bump github.com/cosmos/ledger-cosmos-go from 0.13.3 to 0.14.0 (cosmos#23029) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * feat(x/tx): add an option to encode maps using amino json (backport cosmos#23539) (cosmos#23540) Co-authored-by: Julien Robert <julien@rbrt.fr> * feat(client/v2): add map support (backport cosmos#23544) (cosmos#23554) Co-authored-by: Julien Robert <julien@rbrt.fr> * docs(keyring): add keyctl docs (backport cosmos#23563) (cosmos#23566) Co-authored-by: Alessio Treglia <al@essio.dev> * docs: correct explanation on how to set custom signer via depinject (backport cosmos#23654) (cosmos#23663) Co-authored-by: Julien Robert <julien@rbrt.fr> * chore: remove unused orm module (backport cosmos#23633) (cosmos#23637) Co-authored-by: Zachary Becker <zrbecker@gmail.com> * Merge commit from fork * Prevent empty groups (cherry picked from commit 95090a0ec1f193104ba7d6d033a490d1515e54d8) * Handle inflight proposals (cherry picked from commit 855983471882068894ed7952b592ab3e61b464b9) * No empty group with simulations * Update changelog * Set release date * updates * Update RELEASE_NOTES.md * Update RELEASE_NOTES.md --------- Co-authored-by: Alex Peters <alpe@users.noreply.github.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * Mark v0.50.12-pio-1 in the changelog. --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Julien Robert <julien@rbrt.fr> Co-authored-by: Alessio Treglia <al@essio.dev> Co-authored-by: Zachary Becker <zrbecker@gmail.com>

Co-authored-by: Zachary Becker <zrbecker@gmail.com>

…smos#23633

* Remove the fee handler customization since the SDK added a post handler that does pretty much the same thing. * Make DefaultGasLimit a variable instead of constant. * Fix the post handler response code thing. * Bring in SDK changes up to v0.50.12 and Mark v0.50.12-pio-1. (#614) * build(deps): Bump github.com/cosmos/cosmos-db from 1.1.0 to 1.1.1 (cosmos#23030) * build(deps): Bump github.com/cosmos/ledger-cosmos-go from 0.13.3 to 0.14.0 (cosmos#23029) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * feat(x/tx): add an option to encode maps using amino json (backport cosmos#23539) (cosmos#23540) Co-authored-by: Julien Robert <julien@rbrt.fr> * feat(client/v2): add map support (backport cosmos#23544) (cosmos#23554) Co-authored-by: Julien Robert <julien@rbrt.fr> * docs(keyring): add keyctl docs (backport cosmos#23563) (cosmos#23566) Co-authored-by: Alessio Treglia <al@essio.dev> * docs: correct explanation on how to set custom signer via depinject (backport cosmos#23654) (cosmos#23663) Co-authored-by: Julien Robert <julien@rbrt.fr> * chore: remove unused orm module (backport cosmos#23633) (cosmos#23637) Co-authored-by: Zachary Becker <zrbecker@gmail.com> * Merge commit from fork * Prevent empty groups (cherry picked from commit 95090a0ec1f193104ba7d6d033a490d1515e54d8) * Handle inflight proposals (cherry picked from commit 855983471882068894ed7952b592ab3e61b464b9) * No empty group with simulations * Update changelog * Set release date * updates * Update RELEASE_NOTES.md * Update RELEASE_NOTES.md --------- Co-authored-by: Alex Peters <alpe@users.noreply.github.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * Mark v0.50.12-pio-1 in the changelog. --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Julien Robert <julien@rbrt.fr> Co-authored-by: Alessio Treglia <al@essio.dev> Co-authored-by: Zachary Becker <zrbecker@gmail.com> * Prov: Improve performance of GetAllBalances and GetAccountsBalances. (#616) * Improve performance of GetAllBalances and GetAccountsBalances. * Add changelog entry. * Bring in SDK changes up to v0.50.13 and Mark v0.50.13-pio-1. (#615) * Merge commit from fork * Fix ABS061 * Use typed event * Add changelog * Review feedback * Check for events * Review feedback * Remove unecessary code comments * Set release date * fix changelog --------- Co-authored-by: Alex | Interchain Labs <alex@interchainlabs.io> * Add changelog entry. * Put nothing back at the top of the changelog. --------- Co-authored-by: Alexander Peters <alpe@users.noreply.github.com> Co-authored-by: Alex | Interchain Labs <alex@interchainlabs.io> * Add a bunch of logging. * Revert "Add a bunch of logging." This reverts commit 3baf4d3. * Make the DefaultGasLimit a constant again (back to how the SDK has it). * Add changelog entry. --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Julien Robert <julien@rbrt.fr> Co-authored-by: Alessio Treglia <al@essio.dev> Co-authored-by: Zachary Becker <zrbecker@gmail.com> Co-authored-by: Alexander Peters <alpe@users.noreply.github.com> Co-authored-by: Alex | Interchain Labs <alex@interchainlabs.io>

Co-authored-by: Zachary Becker <zrbecker@gmail.com>

Phase 1 (foundation) of the v0.50.15 -> v0.53.7 migration. NOT building yet. Resolved: - Submodules core/errors/depinject: taken from upstream v0.53.7 (moca's changes were redundant — depinject/appconfig is native in v0.53). - Autogen (.pb.go/.pulsar.go/_grpc.pb.go): taken from v0.53.7, flagged for regeneration from the reconciled protos. - 4 proto conflicts hand-merged (auth/query, base/abci, gov/tx, slashing/tx) — moca additions kept + v0.53 annotations applied. - go.mod/go.sum: v0.53.7 dep graph as base; moca eth deps + cometbft replace to be re-added via `go mod tidy` in Phase 3. - orm/ removed (deleted upstream in v0.53, cosmos#23633). - Project metadata + test fixtures: taken from v0.53.7. Pending (Phase 2 — module reconciliation, 44 files at moca baseline): client(8) x/staking(6) x/gov(4) x/distribution(4) x/auth(4) types(4) simapp(3) x/group(2) x/bank(2) codec(2) feegrant/testutil/store/math/baseapp(1 each) Plus 47 test files at v0.53.7 baseline to re-fix as modules land. Phase 3: regenerate autogen, go mod tidy, unordered-tx ante wiring, x/auth PreBlocker, go build ./... green.

chore: remove unused orm module

65f25e8

zrbecker added C:orm labels Feb 7, 2025

zrbecker requested a review from a team February 7, 2025 02:18

zrbecker requested review from aljo242 and technicallyty February 7, 2025 15:48

ghost assigned aljo242 and technicallyty Feb 7, 2025

zrbecker enabled auto-merge February 7, 2025 15:49

technicallyty approved these changes Feb 7, 2025

View reviewed changes

zrbecker added this pull request to the merge queue Feb 7, 2025

Merged via the queue into main with commit d7f101e Feb 7, 2025

zrbecker deleted the zrb/delete_orm branch February 7, 2025 18:15

mergify Bot pushed a commit that referenced this pull request Feb 7, 2025

chore: remove unused orm module (#23633)

539e4af

(cherry picked from commit d7f101e) # Conflicts: # x/params/proto/buf.gen.pulsar.yaml # x/params/sonar-project.properties

mergify Bot mentioned this pull request Feb 7, 2025

chore: remove unused orm module (backport #23633) #23636

Merged

12 tasks

mergify Bot mentioned this pull request Feb 7, 2025

chore: remove unused orm module (backport #23633) #23637

Merged

12 tasks

aljo242 pushed a commit that referenced this pull request Feb 7, 2025

chore: remove unused orm module (backport #23633) (#23636)

ec6b8fb

Co-authored-by: Zachary Becker <zrbecker@gmail.com>

aljo242 pushed a commit that referenced this pull request Feb 12, 2025

chore: remove unused orm module (backport #23633) (#23637)

158f146

Co-authored-by: Zachary Becker <zrbecker@gmail.com>

aljo242 pushed a commit that referenced this pull request Feb 12, 2025

chore: remove unused orm module (backport #23633) (#23637)

4cc5464

Co-authored-by: Zachary Becker <zrbecker@gmail.com>

aljo242 pushed a commit that referenced this pull request Feb 12, 2025

chore: remove unused orm module (backport #23633) (#23678)

edafb06

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Zachary Becker <zrbecker@gmail.com>

GNaD13 pushed a commit to oraichain/cosmos-sdk that referenced this pull request Apr 15, 2025

chore: remove unused orm module (backport cosmos#23633) (cosmos#23637)

1336753

Co-authored-by: Zachary Becker <zrbecker@gmail.com>

JeancarloBarrios added a commit to agoric-labs/cosmos-sdk that referenced this pull request Jun 4, 2025

fix: remove orm module given that is no longer mantained based com co…

2a05563

…smos#23633

faddat mentioned this pull request Jul 7, 2025

v50superfix #24929

Closed

puneet2019 pushed a commit to persistenceOne/cosmos-sdk that referenced this pull request Jul 30, 2025

chore: remove unused orm module (backport cosmos#23633) (cosmos#23637)

92315a4

Co-authored-by: Zachary Becker <zrbecker@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: remove unused orm module#23633

chore: remove unused orm module#23633
zrbecker merged 1 commit into
mainfrom
zrb/delete_orm

zrbecker commented Feb 7, 2025 •

edited

Loading

Uh oh!

coderabbitai Bot commented Feb 7, 2025 •

edited

Loading

Walkthrough

Changes

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

tac0turtle commented Feb 7, 2025 •

edited

Loading

Uh oh!

zrbecker commented Feb 7, 2025 •

edited

Loading

Uh oh!

aaronc commented Feb 12, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

zrbecker commented Feb 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Author Checklist

Reviewers Checklist

Uh oh!

coderabbitai Bot commented Feb 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

tac0turtle commented Feb 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zrbecker commented Feb 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aaronc commented Feb 12, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

zrbecker commented Feb 7, 2025 •

edited

Loading

coderabbitai Bot commented Feb 7, 2025 •

edited

Loading

tac0turtle commented Feb 7, 2025 •

edited

Loading

zrbecker commented Feb 7, 2025 •

edited

Loading