Skip to content

v50superfix#24929

Closed
faddat wants to merge 14 commits into
cosmos:mainfrom
faddat:v50superfix
Closed

v50superfix#24929
faddat wants to merge 14 commits into
cosmos:mainfrom
faddat:v50superfix

Conversation

@faddat

@faddat faddat commented Jul 7, 2025

Copy link
Copy Markdown
Contributor

Description

Closes: #XXXX

Summary by CodeRabbit

  • Documentation

    • Updated changelog and release notes with new entries, patch releases, and security advisories.
    • Improved and clarified user and developer documentation, including new user guides and updates to module and query documentation.
  • Bug Fixes

    • Addressed potential nil pointer and null pointer exceptions to improve stability.
  • Chores

    • Removed ORM (Object-Relational Mapping) code, documentation, tests, and related files from the codebase.

mergify Bot and others added 14 commits February 12, 2025 10:26
Co-authored-by: Zachary Becker <zrbecker@gmail.com>
* Prevent empty groups

(cherry picked from commit 95090a0ec1f193104ba7d6d033a490d1515e54d8)

* Handle inflight proposals

(cherry picked from commit 855983471882068894ed7952b592ab3e61b464b9)

* No empty group with simulations

* Update changelog

* Set release date

* updates

* Update RELEASE_NOTES.md

* Update RELEASE_NOTES.md

---------

Co-authored-by: Alex Peters <alpe@users.noreply.github.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
Co-authored-by: Eric Warehime <eric.warehime@gmail.com>
Co-authored-by: aljo242 <alex@interchainlabs.io>
Co-authored-by: Tyler <48813565+technicallyty@users.noreply.github.com>
…osmos#23879) (cosmos#23903)

Co-authored-by: mmsqe <mavis@crypto.com>
Co-authored-by: aljo242 <alex@interchainlabs.io>
Co-authored-by: Tyler <48813565+technicallyty@users.noreply.github.com>
Co-authored-by: Alex | Interchain Labs <alex@interchainlabs.io>
* Fix ABS061

* Use typed event

* Add changelog

* Review feedback

* Check for events

* Review feedback

* Remove unecessary code comments

* Set release date

* fix changelog

---------

Co-authored-by: Alex | Interchain Labs <alex@interchainlabs.io>
@coderabbitai

coderabbitai Bot commented Jul 7, 2025

Copy link
Copy Markdown
Contributor

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

This change removes the entire ORM (Object-Relational Mapping) subsystem from the codebase, including all code, tests, documentation, generated files, and protobuf schemas related to ORM. Additionally, it updates changelog and release notes documentation, and makes a minor bug fix in baseapp/abci.go with an associated new test. No changes are made to exported or public entities outside the ORM removal and the baseapp bug fix.

Changes

Files/Paths Change Summary
CHANGELOG.md, RELEASE_NOTES.md Updated changelog and release notes with new entries, bug fixes, and security advisories.
baseapp/abci.go, baseapp/abci_test.go Added nil check in FinalizeBlock defer logic; added a test for this behavior.
docs/docs/build/building-modules/02-messages-and-queries.md Updated and clarified documentation for protobuf Msg services and signers; removed legacy queries.
docs/docs/user/user.md Added new user guide documentation.
orm/... (all files and subdirectories) Deleted entire ORM subsystem: all code, tests, docs, generated files, and protobuf schemas.

Sequence Diagram(s)

Not applicable: The changes are either documentation, a bug fix with a simple nil check, or mass deletion of the ORM subsystem. No new or modified control flow or features are introduced that require a sequence diagram.

Assessment against linked issues

Objective Addressed Explanation
Add fallbacks when incorrect protos are present (24449) No changes related to client/v2, proto fallbacks, or autocli crisis config are present. Only ORM removal, doc updates, and a baseapp bug fix are included.
Improve error handling for misconfigured protos or autocli crisis config (24449) No code changes for error handling or fallbacks in command processing or file handling are present.
Temporarily comment out expedited flag in gov helpers for compatibility (24449) No changes to governance helpers or expedited flag logic are present.

Assessment against linked issues: Out-of-scope changes

Code Change Explanation
Complete removal of the ORM subsystem (orm/..., orm/model/..., orm/internal/..., etc.) The linked issue (#24449) is about proto fallbacks and error handling, not ORM removal. This is unrelated.
Updates to documentation files (docs/docs/build/building-modules/02-messages-and-queries.md, etc.) The linked issue does not mention documentation changes.
Addition of new user guide documentation (docs/docs/user/user.md) Not related to proto fallback or error handling objectives.
Changelog and release notes updates (CHANGELOG.md, RELEASE_NOTES.md) Not relevant to the objectives of handling proto errors or command processing.
Nil check addition and test in baseapp/abci.go and baseapp/abci_test.go Not related to proto fallback, autocli, or governance helpers as described in the linked issue.
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai auto-generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@mergify

mergify Bot commented Jul 7, 2025

Copy link
Copy Markdown
Contributor

⚠️ The sha of the head commit of this PR conflicts with #24930. Mergify cannot evaluate rules on this PR. ⚠️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants