Merged
Conversation
added 2 commits
June 9, 2019 15:26
* master: (50 commits) v10.0.0-alpha.22 add react-dom dev dependenncy Fix SSR for Hooks based implementation (#1148) React-JSS id prop docs and improvements (#1147) v10.0.0-alpha.21 fix changelog add support hint to the changelog (#1145) Sheets management for css() (#1137) Update css-vendor to 2.0.5 (#1142) more articles Small readability improvements (#1138) create sponsors.md (#1139) update karma settings Update css-vendor to 2.0.4 (#1136) v10.0.0-alpha.20 fixing release v10.0.0-alpha.19 fix lerna force-publish flag many more tests and some improvements to styped interface (#1133) v10.0.0-alpha.18 ... # Conflicts: # packages/react-jss/src/index.d.ts
HenriBeck
commented
Jul 6, 2019
kof
reviewed
Jul 7, 2019
kof
approved these changes
Jul 7, 2019
Member
kof
left a comment
kof
left a comment
There was a problem hiding this comment.
I don't know if csstype needs to be direct dependency
Member
|
don't forget the changelog |
|
Any update on this? |
bhupinderbola
pushed a commit
to bhupinderbola/jss
that referenced
this pull request
Sep 17, 2019
* Add types for createUseStyles and improve Style type * Add string support for createUseStyles * Update changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What would you like to add/fix?
Update TS types
Corresponding issue (if exists):
Closes #1132
Closes #1114