Merged
Conversation
added 10 commits
October 22, 2018 21:35
- Added typings field to every package.json file
* origin/add-ts-typings: Scoped keyframes (#888) Update readme.md (#897) Use CSSTOM in default unit plugin (#893) Added .nvmrc (#896) [WIP] DONT MERGE Fix ci (#895) Update ci (#894) Support plugins processing for observables by default (#892) Typed CSSOM values support (#887) Dynamic values full syntax (#878) [jss-plugin-cache] Use WeakMap for cache plugin (#890)
- Added ts-check to CI and pre-commit hook
kof
approved these changes
Oct 29, 2018
Member
kof
left a comment
kof
left a comment
There was a problem hiding this comment.
lgtm, but I can't really validate the quality of types
HenriBeck
pushed a commit
that referenced
this pull request
Nov 16, 2018
…eact-jss/update-theming * origin/react-jss/update-theming: use https on our site remove nag message from postinstall script (#914) [docs] Add Onepixel (#912) Add TS type defs (#889) Don't use undefined as a selector (#906) Ignore undefine, null, or empty value rules when generate style. (#905) Fixed cannot find top level reference issue inside @media query (#900) Improve scripts output (#904) # Conflicts: # packages/react-jss/.size-snapshot.json
Member
|
Is there a reason this is different than what we've written for At first glance, the If the jss maintainers want to own its typings, we should start with what's already in DefinitelyTyped. |
bhupinderbola
pushed a commit
to bhupinderbola/jss
that referenced
this pull request
Sep 17, 2019
* Started on ts typings * - Added tsconfig.json - Added typings field to every package.json file * Added Options to observable plugin * Update jss typings * Rename generateClassName to generateId * Started on react-jss types * - Finished typings for react-jss - Added ts-check to CI and pre-commit hook * Update size-snapshots * Update changelog * Update snapshots
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds ts typings to all of our currently supported packages.
Still missing