remove nag message from postinstall script#914
Merged
kof merged 1 commit intocssinjs:masterfrom Nov 7, 2018
notslang:patch-1
Merged
remove nag message from postinstall script#914kof merged 1 commit intocssinjs:masterfrom notslang:patch-1
kof merged 1 commit intocssinjs:masterfrom
notslang:patch-1
Conversation
Member
|
The suggestion was to use #881 (comment) |
Contributor
Author
|
Oh great, another dependency. Soon I'll need an ad blocker for my terminal. |
Member
|
The idea is that you can put one env variable en disable all packages from logging info there as opposed to dealing with every package. Sounds like a good idea to me |
Contributor
Author
|
I think my solution is far more elegant. It requires zero environment variables and zero additional deps 😉 |
Member
|
Does it also has an integrated reminder for the user to support software where some other people spend a lot of their private time instead of spending it with their families? |
Member
|
TBH I don't care about it, because it simply doesn't bring anything. A few contributors we have came probably not over this channel, so I am just going to merge it. |
HenriBeck
pushed a commit
that referenced
this pull request
Nov 16, 2018
…eact-jss/update-theming * origin/react-jss/update-theming: use https on our site remove nag message from postinstall script (#914) [docs] Add Onepixel (#912) Add TS type defs (#889) Don't use undefined as a selector (#906) Ignore undefine, null, or empty value rules when generate style. (#905) Fixed cannot find top level reference issue inside @media query (#900) Improve scripts output (#904) # Conflicts: # packages/react-jss/.size-snapshot.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #881
I don't know what JSS is (it was installed as a dep of another dep in a project I'm maintaining), but this message shows up in the logs of my CI for every single run and it's getting annoying.