Skip to content

Remove warning from production#980

Merged
TrySound merged 1 commit intomasterfrom
dev-expression
Jan 13, 2019
Merged

Remove warning from production#980
TrySound merged 1 commit intomasterfrom
dev-expression

Conversation

@TrySound
Copy link
Copy Markdown
Member

No description provided.

"bundled": 53619,
"minified": 23302,
"gzipped": 6536,
"bundled": 54135,
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

q: why did esm bundle grow?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because it has now all warnings wrapped with condition

if ("production" !== process.env.NODE_ENV) {
  warning(condition, argument, argument);
}

@TrySound TrySound merged commit c153e3a into master Jan 13, 2019
@TrySound TrySound deleted the dev-expression branch January 13, 2019 10:08
bhupinderbola pushed a commit to bhupinderbola/jss that referenced this pull request Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants