Skip to content

Remove warning from production #980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TrySound merged 1 commit into from
Jan 13, 2019
Merged

Remove warning from production #980

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@
"@babel/preset-flow": "^7.0.0",
"@babel/preset-react": "^7.0.0",
"babel-loader": "^8.0.4",
"babel-plugin-dev-expression": "^0.2.1",
"camelcase": "^5.0.0",
"chalk": "^2.4.1",
"codecov": "^1.0.1",
Expand Down
4 changes: 2 additions & 2 deletions packages/jss-plugin-camel-case/.size-snapshot.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
{
"dist/jss-plugin-camel-case.js": {
"bundled": 2226,
"bundled": 2277,
"minified": 747,
"gzipped": 433
},
"dist/jss-plugin-camel-case.min.js": {
"bundled": 2226,
"bundled": 2277,
"minified": 747,
"gzipped": 433
},
Expand Down
18 changes: 9 additions & 9 deletions packages/jss-plugin-compose/.size-snapshot.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,19 +5,19 @@
"gzipped": 541
},
"dist/jss-plugin-compose.min.js": {
"bundled": 2294,
"minified": 719,
"gzipped": 432
"bundled": 2079,
"minified": 686,
"gzipped": 418
},
"dist/jss-plugin-compose.cjs.js": {
"bundled": 2033,
"minified": 862,
"gzipped": 480
"bundled": 2131,
"minified": 936,
"gzipped": 510
},
"dist/jss-plugin-compose.esm.js": {
"bundled": 1815,
"minified": 690,
"gzipped": 396,
"bundled": 1913,
"minified": 764,
"gzipped": 426,
"treeshaked": {
"rollup": {
"code": 21,
Expand Down
18 changes: 9 additions & 9 deletions packages/jss-plugin-extend/.size-snapshot.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,19 +5,19 @@
"gzipped": 697
},
"dist/jss-plugin-extend.min.js": {
"bundled": 3871,
"minified": 1243,
"gzipped": 597
"bundled": 3741,
"minified": 1225,
"gzipped": 587
},
"dist/jss-plugin-extend.cjs.js": {
"bundled": 3517,
"minified": 1419,
"gzipped": 634
"bundled": 3566,
"minified": 1457,
"gzipped": 660
},
"dist/jss-plugin-extend.esm.js": {
"bundled": 3299,
"minified": 1251,
"gzipped": 565,
"bundled": 3348,
"minified": 1289,
"gzipped": 592,
"treeshaked": {
"rollup": {
"code": 21,
Expand Down
18 changes: 9 additions & 9 deletions packages/jss-plugin-nested/.size-snapshot.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,19 +5,19 @@
"gzipped": 845
},
"dist/jss-plugin-nested.min.js": {
"bundled": 4249,
"minified": 1361,
"gzipped": 738
"bundled": 4061,
"minified": 1330,
"gzipped": 719
},
"dist/jss-plugin-nested.cjs.js": {
"bundled": 3594,
"minified": 1375,
"gzipped": 737
"bundled": 3643,
"minified": 1412,
"gzipped": 762
},
"dist/jss-plugin-nested.esm.js": {
"bundled": 3360,
"minified": 1196,
"gzipped": 655,
"bundled": 3409,
"minified": 1233,
"gzipped": 681,
"treeshaked": {
"rollup": {
"code": 64,
Expand Down
4 changes: 2 additions & 2 deletions packages/jss-plugin-rule-value-observable/.size-snapshot.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
{
"dist/jss-plugin-rule-value-observable.js": {
"bundled": 3504,
"bundled": 3531,
"minified": 1101,
"gzipped": 533
},
"dist/jss-plugin-rule-value-observable.min.js": {
"bundled": 3504,
"bundled": 3531,
"minified": 1101,
"gzipped": 533
},
Expand Down
12 changes: 6 additions & 6 deletions packages/jss-plugin-template/.size-snapshot.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,14 @@
"gzipped": 349
},
"dist/jss-plugin-template.cjs.js": {
"bundled": 1292,
"minified": 650,
"gzipped": 400
"bundled": 1341,
"minified": 686,
"gzipped": 423
},
"dist/jss-plugin-template.esm.js": {
"bundled": 1074,
"minified": 482,
"gzipped": 315,
"bundled": 1123,
"minified": 518,
"gzipped": 341,
"treeshaked": {
"rollup": {
"code": 21,
Expand Down
4 changes: 2 additions & 2 deletions packages/jss-plugin-vendor-prefixer/.size-snapshot.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
{
"dist/jss-plugin-vendor-prefixer.js": {
"bundled": 27779,
"bundled": 27516,
"minified": 9614,
"gzipped": 2634
},
"dist/jss-plugin-vendor-prefixer.min.js": {
"bundled": 27779,
"bundled": 27516,
"minified": 9614,
"gzipped": 2634
},
Expand Down
8 changes: 4 additions & 4 deletions packages/jss-preset-default/.size-snapshot.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
{
"dist/jss-preset-default.js": {
"bundled": 66077,
"bundled": 65798,
"minified": 22853,
"gzipped": 6771
},
"dist/jss-preset-default.min.js": {
"bundled": 65764,
"minified": 22472,
"gzipped": 6584
"bundled": 65044,
"minified": 22390,
"gzipped": 6561
},
"dist/jss-preset-default.cjs.js": {
"bundled": 1329,
Expand Down
8 changes: 4 additions & 4 deletions packages/jss-starter-kit/.size-snapshot.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
{
"dist/jss-starter-kit.js": {
"bundled": 81327,
"bundled": 81048,
"minified": 32915,
"gzipped": 9378
},
"dist/jss-starter-kit.min.js": {
"bundled": 81014,
"minified": 32519,
"gzipped": 9194
"bundled": 80294,
"minified": 32437,
"gzipped": 9166
},
"dist/jss-starter-kit.cjs.js": {
"bundled": 2341,
Expand Down
24 changes: 12 additions & 12 deletions packages/jss/.size-snapshot.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,30 +1,30 @@
{
"dist/jss.js": {
"bundled": 59745,
"bundled": 59740,
"minified": 22374,
"gzipped": 6667
},
"dist/jss.min.js": {
"bundled": 58884,
"minified": 21528,
"gzipped": 6240
"bundled": 58601,
"minified": 21513,
"gzipped": 6230
},
"dist/jss.cjs.js": {
"bundled": 54135,
"minified": 23721,
"gzipped": 6624
"bundled": 54651,
"minified": 24090,
"gzipped": 6647
},
"dist/jss.esm.js": {
"bundled": 53619,
"minified": 23302,
"gzipped": 6536,
"bundled": 54135,
Copy link
Copy Markdown
Member

@kof kof Jan 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

q: why did esm bundle grow?

Copy link
Copy Markdown
Member Author

@TrySound TrySound Jan 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because it has now all warnings wrapped with condition

if ("production" !== process.env.NODE_ENV) {
  warning(condition, argument, argument);
}

"minified": 23671,
"gzipped": 6560,
"treeshaked": {
"rollup": {
"code": 19754,
"code": 19192,
"import_statements": 314
},
"webpack": {
"code": 21260
"code": 20665
}
}
}
Expand Down
8 changes: 4 additions & 4 deletions packages/react-jss/.size-snapshot.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
{
"dist/react-jss.js": {
"bundled": 146682,
"bundled": 145377,
"minified": 48635,
"gzipped": 14427
},
"dist/react-jss.min.js": {
"bundled": 112661,
"minified": 38071,
"gzipped": 11637
"bundled": 111229,
"minified": 37989,
"gzipped": 11616
},
"dist/react-jss.cjs.js": {
"bundled": 16624,
Expand Down
5 changes: 3 additions & 2 deletions rollup.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,14 +35,15 @@ Object.keys(pkg.peerDependencies || {}).forEach(key => {
const external = id => !id.startsWith('.') && !id.startsWith('/')

const getBabelOptions = ({useESModules}) => ({
exclude: '**/node_modules/**',
exclude: /node_modules/,
babelrc: false,
runtimeHelpers: true,
presets: [['@babel/env', {loose: true}], '@babel/flow', '@babel/react'],
plugins: [
['@babel/proposal-class-properties', {loose: true}],
['@babel/transform-runtime', {useESModules}],
['@babel/plugin-proposal-export-namespace-from']
['@babel/plugin-proposal-export-namespace-from'],
['dev-expression']
]
})

Expand Down
5 changes: 5 additions & 0 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2122,6 +2122,11 @@ babel-loader@^8.0.4:
mkdirp "^0.5.1"
util.promisify "^1.0.0"

babel-plugin-dev-expression@^0.2.1:
version "0.2.1"
resolved "https://registry.yarnpkg.com/babel-plugin-dev-expression/-/babel-plugin-dev-expression-0.2.1.tgz#d4a7beefefbb50e3f2734990a82a2486cf9eb9ee"
integrity sha1-1Ke+7++7UOPyc0mQqCokhs+eue4=

backo2@1.0.2:
version "1.0.2"
resolved "https://registry.yarnpkg.com/backo2/-/backo2-1.0.2.tgz#31ab1ac8b129363463e35b3ebb69f4dfcfba7947"
Expand Down
⚡