feat: DH-19501: Expose Aggregated Columns in JSTreeTable#6943
Merged
vbabich merged 9 commits intodeephaven:mainfrom Jun 18, 2025
Merged
feat: DH-19501: Expose Aggregated Columns in JSTreeTable#6943vbabich merged 9 commits intodeephaven:mainfrom
vbabich merged 9 commits intodeephaven:mainfrom
Conversation
vbabich
changed the title
vbabich
requested review from
a team and
ethanalvizo
and removed request for
a team and
ethanalvizo
vbabich
added
NoReleaseNotesNeeded
niloc132
reviewed
Jun 12, 2025
Member
niloc132
left a comment
niloc132
left a comment
There was a problem hiding this comment.
Looks like it should be correct to me - add some integration tests to confirm? With constituents and without, with unagg'd columns left in when the rollup is made, etc
Contributor
Author
Added unit tests, found and fixed the issue where |
niloc132
reviewed
Jun 17, 2025
niloc132
approved these changes
Jun 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.