Skip to content

fix: DH-18906: Enable filters on constituent columns in rollups#2463

Merged
vbabich merged 10 commits intodeephaven:mainfrom
vbabich:exclude-aggregated-columns-from-filterable
Jun 26, 2025
Merged

fix: DH-18906: Enable filters on constituent columns in rollups#2463
vbabich merged 10 commits intodeephaven:mainfrom
vbabich:exclude-aggregated-columns-from-filterable

Conversation

@vbabich
Copy link
Copy Markdown
Collaborator

@vbabich vbabich commented Jun 16, 2025

  • Enable filters on constituent columns in Core+ rollups
  • Disable filters on aggregated columns
  • Update jsapi-types to 1.0.0-dev0.39.4

This PR is dependent on deephaven/deephaven-core#6943

@vbabich vbabich self-assigned this Jun 16, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.58%. Comparing base (5b572c3) to head (b2ff3af).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2463      +/-   ##
==========================================
+ Coverage   44.54%   44.58%   +0.04%     
==========================================
  Files         759      759              
  Lines       42526    42542      +16     
  Branches    10877    10883       +6     
==========================================
+ Hits        18942    18968      +26     
- Misses      23528    23563      +35     
+ Partials       56       11      -45     
Flag Coverage Δ
unit 44.58% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vbabich vbabich requested a review from mofojed June 18, 2025 19:34
mofojed
mofojed previously approved these changes Jun 20, 2025
@vbabich vbabich marked this pull request as ready for review June 26, 2025 17:58
@vbabich vbabich merged commit 35046d1 into deephaven:main Jun 26, 2025
12 checks passed
@vbabich vbabich deleted the exclude-aggregated-columns-from-filterable branch June 26, 2025 20:15
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants