feat: DH-18354 Add input filter support to UITable by mattrunyon · Pull Request #1180 · deephaven/deephaven-plugins

mattrunyon · 2025-05-08T18:04:26Z

Until deephaven/web-client-ui#2438 is merged, released, and updated in core, e2e tests will timeout after a few hrs, so I just cancelled the e2e run

I tested with this snippet. Then added an input filter and checked that all columns showed up and worked. Also tested clear all filters button and shortcut

from deephaven import ui, empty_table
from deephaven.plot import express as dx

_stocks = dx.data.stocks()

my_tabs_basic = ui.flex(
    ui.table(_stocks),
    empty_table(10).update("I=i"),
)

github-actions · 2025-05-08T18:07:28Z

ui docs preview (Available for 14 days)

github-actions · 2025-05-08T23:18:50Z

ui docs preview (Available for 14 days)

Copilot

Pull Request Overview

This PR implements input filter support for UITable as part of DH-18354 and fixes issue #1080. Key changes include:

Adding the dashboard core plugins to the Vite config.
Updating transformNode and related tests to enforce unique element IDs (__dhId).
Propagating a new widget "id" prop across WidgetHandler and its consumers, as well as passing down inputFilters to UITable.

Reviewed Changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
plugins/ui/src/js/vite.config.ts	Added alias for dashboard-core-plugins to support input filters.
plugins/ui/src/js/src/widget/WidgetUtils.tsx	Updated transformNode to add __dhId propagation along with tests.
plugins/ui/src/js/src/widget/WidgetHandler.tsx	Introduced and passed the "id" prop for widget identity tracking.
plugins/ui/src/js/src/widget/WidgetHandler.test.tsx	Updated tests to account for new id prop requirements.
plugins/ui/src/js/src/widget/DashboardWidgetHandler.tsx	Propagated the id prop to the WidgetHandler.
plugins/ui/src/js/src/layout/ReactPanel.tsx	Wrapped content with DhIdContext to support the new id flow.
plugins/ui/src/js/src/elements/utils/ElementUtils.tsx & tests	Added __dhId propagation to ObjectView wrapping of exported objects.
plugins/ui/src/js/src/elements/UITable/UITable.tsx	Imported and passed inputFilters to IrisGrid from dashboard core plugins.
plugins/ui/src/js/src/elements/ObjectView.tsx	Updated ObjectView props to accept and propagate __dhId.
plugins/ui/src/js/package.json	Updated dependency versions to integrate the input filter changes.

Comments suppressed due to low confidence (2)

plugins/ui/src/js/src/widget/WidgetHandler.tsx:215

[nitpick] Consider renaming the 'id' parameter passed to transformNode (and the corresponding prop across components) to a more descriptive name like 'rootId' to clarify its purpose in the unique __dhId generation.

const hydratedDocument = transformNode(doc, (key, value) => {

plugins/ui/src/js/package.json:43

Double-check that the dependency version changes (e.g. downgrading from 0.109.0 to 0.108.1-input-filters.21) are intentional and compatible with the rest of the ecosystem.

"@deephaven/chart": "0.108.1-input-filters.21",

github-actions · 2025-05-28T22:30:28Z

ui docs preview (Available for 14 days)

mofojed

Seeing some strange IDs when using tabs.

mofojed · 2025-05-30T14:02:45Z

    };
  }, [irisGridServerProps, initialHydratedState]);

+  const inputFilters = useDashboardColumnFilters(model?.columns ?? EMPTY_ARRAY);


We should be passing the table here as well if the model has a table.
What else do we need for ChartBuilder? I guess we need a stable way to fetch the table as well so we can refetch it on reload...

The table for chart builder is actually sent with the event (not a fetch function). Although we could send the fetch function, but that would change if the table changes. So not sure how we would want to handle that.

Other than that, there's a relatively short handleCreateChart function in IrisGridPanel that would need to have its logic added to a hook that can be used by GridWidgetPlugin and UITable and pass the handler to IrisGrid in each of those

github-actions · 2025-06-02T21:23:30Z

ui docs preview (Available for 14 days)

github-actions · 2025-06-11T19:23:46Z

ui docs preview (Available for 14 days)

mattrunyon · 2025-06-13T19:00:49Z

I need to add clearAllFilters handler still. Forgot I didn't put it in the useDashboardColumnFilters and left it as a separate handler since we call irisGrid.clearAllFilters() which clears more than just column filters

github-actions · 2025-06-13T20:54:27Z

ui docs preview (Available for 14 days)

github-actions · 2025-06-13T21:03:43Z

ui docs preview (Available for 14 days)

github-actions · 2025-06-13T21:11:40Z

ui docs preview (Available for 14 days)

github-actions · 2025-06-13T21:22:03Z

ui docs preview (Available for 14 days)

This builds on top of #1180 and the actual linker code is relatively simple because of the hook from deephaven/web-client-ui#2459 Tested with test plan in DH-18836

mattrunyon self-assigned this May 8, 2025

mattrunyon added 4 commits May 22, 2025 00:53

feat: Add input filter support to UITable

4a6a55b

Temp IDs for input filters

10e4036

Update and add tests

f31ae5e

Update to alpha and fix type error

68f2ecf

mattrunyon force-pushed the mattrunyon_dh-18354 branch from cbae21c to 68f2ecf Compare May 28, 2025 22:25

mattrunyon changed the title ~~feat: Add input filter support to UITable~~ feat: DH-18354 Add input filter support to UITable May 28, 2025

mattrunyon marked this pull request as ready for review May 28, 2025 22:26

mattrunyon requested review from Copilot and mofojed May 28, 2025 22:26

Copilot AI reviewed May 28, 2025

View reviewed changes

mofojed requested changes May 30, 2025

View reviewed changes

Address review comments

f11c0b4

mattrunyon requested a review from mofojed June 2, 2025 21:20

mofojed requested changes Jun 5, 2025

View reviewed changes

Comment thread plugins/ui/src/js/src/widget/WidgetUtils.tsx Outdated

Address review comments

92031ed

mattrunyon requested a review from mofojed June 11, 2025 19:25

mattrunyon mentioned this pull request Jun 11, 2025

feat: DH-18836 Add support for linker to UITable #1187

Merged

Add clear all filters

cd02434

Update to 1.0.0 packages

efc76e6

Switch to PanelIdContext

89e9bfd

Fix unit tests

a87d6dc

mofojed approved these changes Jun 17, 2025

View reviewed changes

mattrunyon merged commit edd9397 into deephaven:main Jun 17, 2025
16 of 17 checks passed

Conversation

mattrunyon commented May 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented May 8, 2025

Uh oh!

github-actions Bot commented May 8, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

github-actions Bot commented May 28, 2025

Uh oh!

mofojed left a comment

Choose a reason for hiding this comment

Uh oh!

mofojed May 30, 2025

Choose a reason for hiding this comment

Uh oh!

mattrunyon May 30, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Jun 2, 2025

Uh oh!

Uh oh!

github-actions Bot commented Jun 11, 2025

Uh oh!

mattrunyon commented Jun 13, 2025

Uh oh!

github-actions Bot commented Jun 13, 2025

Uh oh!

github-actions Bot commented Jun 13, 2025

Uh oh!

github-actions Bot commented Jun 13, 2025

Uh oh!

github-actions Bot commented Jun 13, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

mattrunyon commented May 8, 2025 •

edited

Loading