feat: Double click notebook tab to remove its preview status#1190
Merged
mattrunyon merged 2 commits intodeephaven:mainfrom Mar 30, 2023
Merged
feat: Double click notebook tab to remove its preview status#1190mattrunyon merged 2 commits intodeephaven:mainfrom
mattrunyon merged 2 commits intodeephaven:mainfrom
Conversation
mofojed
previously approved these changes
Mar 30, 2023
Codecov Report
@@ Coverage Diff @@
## main #1190 +/- ##
========================================
Coverage 44.19% 44.19%
========================================
Files 448 448
Lines 33308 33424 +116
Branches 8362 8404 +42
========================================
+ Hits 14719 14771 +52
- Misses 18540 18603 +63
- Partials 49 50 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 4 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
mofojed
approved these changes
Mar 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Something I noticed while working on #1189 is that we didn't support double clicking the tab to promote from preview to normal state like VSCode does. This PR lets you double click the tab of a notebook in preview to change it from preview state to normal state.
Tested double clicking preview notebook, non-preview notebook, and opening other notebooks in preview after promoting via double click