Description
Right now if the JS API throws a reconnect auth fail error, the embed-widget (embed-grid/embed-chart deprecated) packages do not handle it. The change #1149 to wire up the reconnect auth fail event only added it to code-studio package, so the embed-widget package would not react the same.
Possibly add it to AppBootstrap or some other common component between the three packages.
Follow these steps to reproduce an auth failure:
- Start up server with deephaven-core
- Use ngrok to start a tunnel to that port, e.g.: ngrok http 10000
- Start up Web UI connecting to that tunnel, e.g.: VITE_CORE_API_URL=http://acfc-23-233-0-34.ngrok.io/jsapi npm start
- Open the Web UI in Firefox, run some commands to make sure initial connection is fine.
- Press Alt and from the File menu, select "Work Offline"
- See it transition to a disconnected state. Disconnected message should appear and should not be able to enter new commands
- Reconnect by deselecting "Work Offline" option from Step 5
- See it transition to connected state. Should be able to run commands and have the results appear.
- Kill the server (Ctrl+C). See it transition to a Shutdown state, app unloaded.
Description
Right now if the JS API throws a reconnect auth fail error, the embed-widget (embed-grid/embed-chart deprecated) packages do not handle it. The change #1149 to wire up the reconnect auth fail event only added it to
code-studiopackage, so theembed-widgetpackage would not react the same.Possibly add it to
AppBootstrapor some other common component between the three packages.Follow these steps to reproduce an auth failure: