fix: Reconnect Auth Fail Fix - embed-widget#2023
fix: Reconnect Auth Fail Fix - embed-widget#2023AkshatJawne merged 17 commits intodeephaven:mainfrom
Conversation
mattrunyon
left a comment
There was a problem hiding this comment.
I also noticed this doesn't stop listening when the server is shutdown which is different behavior than what we currently have. I tested this by just stopping/starting the core server. The app showed the "auth failed" modal in that case. Previously this would just stay on the "Server shutdown" component.
@mattrunyon Have been testing on my local branch, not able to reproduce, when I shut down the core server and start it again, I do not see the "auth failed" modal, it just stays on the "Server shutdown". |
|
Changed test case based on new logic, until the connection is resolved, it will show the modal, and hence for the first assertion of the connection bootstrap, should not be null. |
mattrunyon
left a comment
There was a problem hiding this comment.
Will still need @mofojed to review again. I want to make sure he's ok w/ the state names as well.
Changes for the states could be not_connecting -> errored. And failed -> authFailed instead. I'm indifferent though
Resolves #1256
Changes Implemented:
ConnectionBootstrapin order to properly handle auth fail event in theembed-widgetVisual of modal that appears on auth fail:
