-
Notifications
You must be signed in to change notification settings - Fork 33
fix: Reconnect Auth Fail Fix - embed-widget #2023
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
AkshatJawne
merged 17 commits into
deephaven:main
from
AkshatJawne:1256-embed-widget-auth-fail-fix
Jun 12, 2024
Merged
Changes from 11 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
eeb833e
Implement auth fail logic in connection bootstrap
AkshatJawne ae91c86
Remove unneccessary fonts in embed-widget
AkshatJawne 2a94648
Modify test cases to accommodate new logic
AkshatJawne 0a71c49
Make changes based on review
AkshatJawne 59ae16e
make changes to ConnectionBootstrap
AkshatJawne d4b817e
Merge branch 'main' into 1256-embed-widget-auth-fail-fix
AkshatJawne 7e97e9d
change logic for showing modal
AkshatJawne f219964
remove unneccessary imports
AkshatJawne c8346ba
remove unneccessary event listeners in main container and add listene…
AkshatJawne ad80209
Merge branch 'main' into 1256-embed-widget-auth-fail-fix
AkshatJawne 5af39ca
make changes based on review
AkshatJawne ffe1ce0
add back styling file for embed-widget
AkshatJawne ae65ad5
resolve merge conflicts
AkshatJawne 1a00788
modify state and modal rendering logic
AkshatJawne 77fa6df
remove icon
AkshatJawne 8bbff5e
fix unit test failures"
AkshatJawne 23a34a4
add not_connecting state
AkshatJawne File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.