fix: Upgrade Monaco to ^0.41.0#1448
Merged
bmingles merged 9 commits intodeephaven:mainfrom Aug 16, 2023
Merged
Conversation
3c0c257 to
a449d2c
Compare
Codecov Report
@@ Coverage Diff @@
## main #1448 +/- ##
==========================================
- Coverage 45.70% 45.70% -0.01%
==========================================
Files 513 513
Lines 35067 35046 -21
Branches 8787 8781 -6
==========================================
- Hits 16027 16017 -10
+ Misses 18989 18978 -11
Partials 51 51
Flags with carried forward coverage won't be shown. Click here to find out more.
|
mofojed
requested changes
Aug 16, 2023
Member
mofojed
left a comment
There was a problem hiding this comment.
Just the command history shortcut no longer working.
| }; | ||
| assertNotNull(this.container); | ||
|
|
||
| MonacoUtils.removeConflictingKeybindings(); |
Member
There was a problem hiding this comment.
We could just call this from MonacoUtils.init, and then don't need to check in the function if it's been called more than once.
mofojed
previously approved these changes
Aug 16, 2023
mattrunyon
requested changes
Aug 16, 2023
mattrunyon
requested changes
Aug 16, 2023
mattrunyon
approved these changes
Aug 16, 2023
Collaborator
mofojed
approved these changes
Aug 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1445, fixes #1191 Fixing Monaco bug by upgrading to latest ^0.41.0
Supports DH-15438
BREAKING CHANGE: Monaco will need to be upgraded to ^0.41.0 in Enterprise to ensure compatibility
Tests Performed
Cmd+Fdoes nothingEscEscdoes not close find inputEscdoes clear selection when focus is in the log content