Skip to content

fix: Upgrade Monaco to ^0.41.0#1448

Merged
bmingles merged 9 commits intodeephaven:mainfrom
bmingles:1445_monaco-upgrade
Aug 16, 2023
Merged

fix: Upgrade Monaco to ^0.41.0#1448
bmingles merged 9 commits intodeephaven:mainfrom
bmingles:1445_monaco-upgrade

Conversation

@bmingles
Copy link
Copy Markdown
Contributor

@bmingles bmingles commented Aug 15, 2023

Fixes #1445, fixes #1191 Fixing Monaco bug by upgrading to latest ^0.41.0

Supports DH-15438

BREAKING CHANGE: Monaco will need to be upgraded to ^0.41.0 in Enterprise to ensure compatibility

Tests Performed

  • Console Input
    • Cmd+F does nothing
    • Intellisense can be closed via Esc
  • Log tab
    • Esc does not close find input
    • Esc does clear selection when focus is in the log content
  • Code Editor
    • Verified that newline with leading space no longer crashes the browser tab
      a
       a
      
    • Wrote some Python code. Intellisense, syntax highlighting, and general typing experience seemed as expected
    • Execute full code + selected code successfully

@bmingles bmingles force-pushed the 1445_monaco-upgrade branch from 3c0c257 to a449d2c Compare August 15, 2023 19:50
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 15, 2023

Codecov Report

Merging #1448 (253c8b5) into main (e3b4cf2) will decrease coverage by 0.01%.
Report is 1 commits behind head on main.
The diff coverage is 35.29%.

@@            Coverage Diff             @@
##             main    #1448      +/-   ##
==========================================
- Coverage   45.70%   45.70%   -0.01%     
==========================================
  Files         513      513              
  Lines       35067    35046      -21     
  Branches     8787     8781       -6     
==========================================
- Hits        16027    16017      -10     
+ Misses      18989    18978      -11     
  Partials       51       51              
Flag Coverage Δ
unit 45.70% <35.29%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
packages/console/src/log/LogView.tsx 0.00% <0.00%> (ø)
packages/console/src/notebook/Editor.tsx 0.00% <ø> (ø)
packages/console/src/monaco/MonacoUtils.ts 58.40% <71.42%> (-3.02%) ⬇️
packages/console/src/ConsoleInput.tsx 67.85% <100.00%> (+0.15%) ⬆️

... and 1 file with indirect coverage changes

@bmingles bmingles requested review from mattrunyon and mofojed August 15, 2023 21:06
Copy link
Copy Markdown
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the command history shortcut no longer working.

Comment thread packages/console/src/log/LogView.tsx Outdated
Comment thread packages/console/src/monaco/MonacoUtils.ts Outdated
Comment thread packages/console/src/monaco/MonacoUtils.ts Outdated
Comment thread packages/console/src/monaco/MonacoUtils.ts Outdated
};
assertNotNull(this.container);

MonacoUtils.removeConflictingKeybindings();
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could just call this from MonacoUtils.init, and then don't need to check in the function if it's been called more than once.

Comment thread packages/iris-grid/src/sidebar/CustomColumnBuilder.test.tsx Outdated
@bmingles bmingles requested a review from mofojed August 16, 2023 15:02
mofojed
mofojed previously approved these changes Aug 16, 2023
Comment thread packages/console/src/monaco/MonacoUtils.ts Outdated
Comment thread packages/console/src/monaco/MonacoUtils.ts Outdated
Comment thread packages/console/src/monaco/MonacoUtils.ts Outdated
Comment thread packages/console/src/monaco/MonacoUtils.ts Outdated
Comment thread packages/console/src/monaco/MonacoUtils.ts Outdated
@bmingles bmingles requested a review from mattrunyon August 16, 2023 18:53
@mattrunyon
Copy link
Copy Markdown
Collaborator

@dsmmcken This enables bracket colorization. Did you want to open a ticket to change the default bracket colors? The keys are here under Bracket pair colorization

I also noticed the command history does not colorize the brackets, but does have colorization. Odd

@bmingles bmingles merged commit 1120c2b into deephaven:main Aug 16, 2023
@bmingles bmingles deleted the 1445_monaco-upgrade branch August 16, 2023 21:36
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Typing newline then space in InputEditor Component Crashes Chrome Notebook mouse wheel and new LSP feature

3 participants