fix: Dashboard plugin crashing UI on throw#2080
Merged
AkshatJawne merged 8 commits intodeephaven:mainfrom Jun 17, 2024
Merged
Conversation
Contributor
Author
|
Will look into failures here |
Contributor
Author
|
Will remove commented out code if approach works |
mattrunyon
requested changes
Jun 14, 2024
Collaborator
mattrunyon
left a comment
mattrunyon
left a comment
There was a problem hiding this comment.
Update the PR body as well. Looks like what you listed was the original fix attempt
mattrunyon
approved these changes
Jun 17, 2024
Collaborator
mattrunyon
left a comment
mattrunyon
left a comment
There was a problem hiding this comment.
Looks good. Also at least prevents the crash in deephaven/deephaven-plugins#510 but that ticket still documents bad behavior in Deephaven UI, so it should stay open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1771
Changes Implemented:
ErrorBoundaryaround cloning of Dashboard Plugin in DashboardLayout