Skip to content

fix: Dashboard plugin crashing UI on throw #2080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AkshatJawne merged 8 commits into from
Jun 17, 2024
Merged

fix: Dashboard plugin crashing UI on throw #2080

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b883f15
fix: Dashboard plugin crashing UI on throw
AkshatJawne Jun 13, 2024
182e331
Merge branch 'main' into 1771_dashboard_plugin_error_fix
AkshatJawne Jun 14, 2024
16f479b
try different approach for wrapping error boundary
AkshatJawne Jun 14, 2024
c6ea09c
remove error throw
AkshatJawne Jun 14, 2024
feb8894
remove unneccessary import
AkshatJawne Jun 14, 2024
b92a67d
WIP trying to use PanelErrorBoundary
AkshatJawne Jun 14, 2024
fb0d087
modify ErrorBoundary position
AkshatJawne Jun 14, 2024
e550bd9
Make change based on review
AkshatJawne Jun 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions packages/dashboard/src/DashboardLayout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ import type {
} from '@deephaven/golden-layout';
import Log from '@deephaven/log';
import { usePrevious, useThrottledCallback } from '@deephaven/react-hooks';
import { ErrorBoundary } from '@deephaven/components';
import { RootState } from '@deephaven/redux';
import { useDispatch, useSelector } from 'react-redux';
import PanelManager, { ClosedPanels } from './PanelManager';
Expand Down Expand Up @@ -343,14 +344,16 @@ export function DashboardLayout({
{isDashboardEmpty && emptyDashboard}
{layoutChildren}
{React.Children.map(children, child =>
child != null
? React.cloneElement(child as ReactElement, {
child != null ? (
<ErrorBoundary fallback={[]}>
Comment thread
AkshatJawne marked this conversation as resolved.
{React.cloneElement(child as ReactElement, {
id,
layout,
panelManager,
registerComponent,
})
: null
})}
</ErrorBoundary>
) : null
)}
</>
);
Expand Down
2 changes: 0 additions & 2 deletions tests/docker-scripts/docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
version: '3.8'

services:
dhc-server:
container_name: dhc-server
Expand Down
⚡