Skip to content

fix: allow overflow scroll for widget list and dashboard overlow list.#2558

Merged
mofojed merged 2 commits intomainfrom
dmckenzie_fix_dash_overflow_menu
Nov 3, 2025
Merged

fix: allow overflow scroll for widget list and dashboard overlow list.#2558
mofojed merged 2 commits intomainfrom
dmckenzie_fix_dash_overflow_menu

Conversation

@dsmmcken
Copy link
Copy Markdown
Contributor

@dsmmcken dsmmcken commented Oct 29, 2025

Dashboard list overflows, but would not be selectable, made selectable and extend over to overflow. Panels list would wrap text (which worked before it was a spectrum list, which now needs same height items), now overflow scroll on x and y.

Before:
image

After:
image

@dsmmcken dsmmcken changed the title Fix: allow overflow scroll for widget list and dashboard overlow list. fix: allow overflow scroll for widget list and dashboard overlow list. Oct 29, 2025
@dsmmcken dsmmcken requested a review from mofojed October 29, 2025 14:21
@dsmmcken dsmmcken self-assigned this Oct 29, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 44.36%. Comparing base (4ee9308) to head (7b9b7ee).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2558      +/-   ##
==========================================
+ Coverage   44.08%   44.36%   +0.28%     
==========================================
  Files         764      764              
  Lines       43078    43104      +26     
  Branches    11066    10895     -171     
==========================================
+ Hits        18990    19125     +135     
+ Misses      24041    23963      -78     
+ Partials       47       16      -31     
Flag Coverage Δ
unit 44.36% <ø> (+0.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With only two dashboards, it looks strange. Tested with:

from deephaven import ui

fjdsiopajfiodjsaoifjdsoiafjdiosajfoidsjafoidjsaoifjdsoiajfds = ui.dashboard(ui.panel("Hello"))
fjdsiopajfiodjsaoifjdsoiafjdiosajfoidsjafoidjsaoifjdsoiajfds2 = ui.dashboard(ui.panel("Hello"))
Image Image

The right arrow seems to overlap the last characters of the last dashboard in the list, and pressing on the right arrow doesn't seem to work...:

Image

Looks good when the lists are full though

@dsmmcken
Copy link
Copy Markdown
Contributor Author

dsmmcken commented Oct 30, 2025

NavTabList isn't re-used in enterprise -- it's actually quite a few bugs behind what looks like we refactored here. Probably worth de-duplicating to pick up the various bug fixes.

Fixed case when left edge of tab is still on screen at the right, but the right edge of a tab is offscreen to the right, and it not scrolling in.

Fixed list for less than full amount of items.

@dsmmcken dsmmcken requested a review from mofojed October 30, 2025 17:58
@mofojed mofojed merged commit 4d955b4 into main Nov 3, 2025
16 of 18 checks passed
@mofojed mofojed deleted the dmckenzie_fix_dash_overflow_menu branch November 3, 2025 20:02
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants