fix: allow overflow scroll for widget list and dashboard overlow list.#2558
fix: allow overflow scroll for widget list and dashboard overlow list.#2558
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2558 +/- ##
==========================================
+ Coverage 44.08% 44.36% +0.28%
==========================================
Files 764 764
Lines 43078 43104 +26
Branches 11066 10895 -171
==========================================
+ Hits 18990 19125 +135
+ Misses 24041 23963 -78
+ Partials 47 16 -31
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mofojed
left a comment
There was a problem hiding this comment.
With only two dashboards, it looks strange. Tested with:
from deephaven import ui
fjdsiopajfiodjsaoifjdsoiafjdiosajfoidsjafoidjsaoifjdsoiajfds = ui.dashboard(ui.panel("Hello"))
fjdsiopajfiodjsaoifjdsoiafjdiosajfoidsjafoidjsaoifjdsoiajfds2 = ui.dashboard(ui.panel("Hello"))
The right arrow seems to overlap the last characters of the last dashboard in the list, and pressing on the right arrow doesn't seem to work...:
Looks good when the lists are full though
|
NavTabList isn't re-used in enterprise -- it's actually quite a few bugs behind what looks like we refactored here. Probably worth de-duplicating to pick up the various bug fixes. Fixed case when left edge of tab is still on screen at the right, but the right edge of a tab is offscreen to the right, and it not scrolling in. Fixed list for less than full amount of items. |
Dashboard list overflows, but would not be selectable, made selectable and extend over to overflow. Panels list would wrap text (which worked before it was a spectrum list, which now needs same height items), now overflow scroll on x and y.
Before:

After:
