Skip to content

fix: Fix OneClick links not filtering plots#1217

Merged
vbabich merged 4 commits intodeephaven:mainfrom
vbabich:one-clicks-1198
Apr 17, 2023
Merged

fix: Fix OneClick links not filtering plots#1217
vbabich merged 4 commits intodeephaven:mainfrom
vbabich:one-clicks-1198

Conversation

@vbabich
Copy link
Copy Markdown
Collaborator

@vbabich vbabich commented Apr 11, 2023

  • Update ChartPanel to get the filter value from filterList
  • Hide operator selection for filter source and chart links
  • Don't allow linking multiple columns from the same table to a chart target
  • Fix issue with link in progress not being reset after creating a new link

Fixes #1198

@vbabich vbabich self-assigned this Apr 11, 2023
@vbabich vbabich requested a review from mofojed April 11, 2023 15:57
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 11, 2023

Codecov Report

Merging #1217 (d84daf5) into main (85ce600) will increase coverage by 0.77%.
The diff coverage is 16.66%.

@@            Coverage Diff             @@
##             main    #1217      +/-   ##
==========================================
+ Coverage   44.26%   45.03%   +0.77%     
==========================================
  Files         450      450              
  Lines       33480    33509      +29     
  Branches     8420     8439      +19     
==========================================
+ Hits        14820    15091     +271     
+ Misses      18610    18368     -242     
  Partials       50       50              
Flag Coverage Δ
unit 45.03% <16.66%> (+0.77%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/chart/src/ChartModel.ts 40.74% <0.00%> (ø)
packages/chart/src/ChartUtils.ts 64.19% <ø> (ø)
packages/chart/src/FigureChartModel.ts 53.33% <0.00%> (ø)
...kages/dashboard-core-plugins/src/linker/Linker.tsx 37.57% <0.00%> (+12.64%) ⬆️
...d-core-plugins/src/linker/LinkerOverlayContent.tsx 57.14% <ø> (+27.73%) ⬆️
...s/dashboard-core-plugins/src/linker/LinkerUtils.ts 88.33% <0.00%> (+84.94%) ⬆️
...s/dashboard-core-plugins/src/panels/ChartPanel.tsx 60.94% <0.00%> (-0.53%) ⬇️
...s/dashboard-core-plugins/src/linker/LinkerLink.tsx 94.93% <85.71%> (+87.83%) ⬆️

... and 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Comment thread packages/dashboard-core-plugins/src/linker/Linker.tsx
Comment thread packages/dashboard-core-plugins/src/panels/ChartPanel.tsx Outdated
@vbabich vbabich requested a review from mofojed April 17, 2023 16:08
@vbabich vbabich merged commit 9b20f9e into deephaven:main Apr 17, 2023
@vbabich vbabich deleted the one-clicks-1198 branch April 17, 2023 17:20
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Linker with one click plots doesn't filter plot

2 participants