Skip to content

build: Use Vite HTML env variable replacement#1304

Merged
mattrunyon merged 1 commit intodeephaven:mainfrom
mattrunyon:vite-html-env-variables
May 19, 2023
Merged

build: Use Vite HTML env variable replacement#1304
mattrunyon merged 1 commit intodeephaven:mainfrom
mattrunyon:vite-html-env-variables

Conversation

@mattrunyon
Copy link
Copy Markdown
Collaborator

@mattrunyon mattrunyon commented May 16, 2023

Fixes #1161

Also fixed an embed-grid/embed-chart Vite proxy server issue in preview mode

Tested by running npm start and looking at those tags in the head which should be replaced (base, npm version, favicon). Then ran npm run build and npm run preview and checked the tags in the built version

@mattrunyon mattrunyon requested a review from mofojed May 16, 2023 20:57
@mattrunyon mattrunyon self-assigned this May 16, 2023
@codecov
Copy link
Copy Markdown

codecov Bot commented May 16, 2023

Codecov Report

Merging #1304 (3f220c4) into main (d304300) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1304   +/-   ##
=======================================
  Coverage   45.89%   45.89%           
=======================================
  Files         492      492           
  Lines       34371    34371           
  Branches     8566     8566           
=======================================
  Hits        15775    15775           
  Misses      18545    18545           
  Partials       51       51           
Flag Coverage Δ
unit 45.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@mattrunyon mattrunyon merged commit f0d4989 into deephaven:main May 19, 2023
@github-actions github-actions Bot locked and limited conversation to collaborators May 19, 2023
@mattrunyon mattrunyon deleted the vite-html-env-variables branch June 23, 2024 06:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Switch to Vite HTML env variable replacement

2 participants