revert: "refactor: Clean up golden-layout css (#1322)"#1334
Merged
mofojed merged 1 commit intodeephaven:mainfrom May 31, 2023
Merged
revert: "refactor: Clean up golden-layout css (#1322)"#1334mofojed merged 1 commit intodeephaven:mainfrom
mofojed merged 1 commit intodeephaven:mainfrom
Conversation
dsmmcken
approved these changes
May 31, 2023
This reverts commit d1838d7.
658a272 to
ef89cbc
Compare
Codecov Report
@@ Coverage Diff @@
## main #1334 +/- ##
=======================================
Coverage ? 45.95%
=======================================
Files ? 493
Lines ? 34414
Branches ? 8582
=======================================
Hits ? 15814
Misses ? 18549
Partials ? 51
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit d1838d7.
Was getting build errors when consuming in Enterprise:
In the
dist/GoldenLayoutThemeExport.js, the import ends up being:But in the scss folder it’s
GoldenLayout.module.scss, not.cssThe babel preset converts the scss imports to css:
Will need to resolve this issue before re-merging this refactor.