fix: Replace shortid package with nanoid package#2025
fix: Replace shortid package with nanoid package#2025AkshatJawne merged 11 commits intodeephaven:mainfrom
Conversation
|
Looking into errors here |
|
Remove In transform: [
['babelify', { presets: ['@babel/preset-env'], global: true }],
],This seems to fix the issue by using babel to transpile the ESM before the bundling for the test. |
|
LGTM. Will wait for @mattrunyon to approve since he suggested the babelify change, and I'm less familiar here |
|
Sounds good, thanks @bmingles |
mattrunyon
left a comment
There was a problem hiding this comment.
There's a @types/shortid in the root package.json still. Remove it and run npm install again so it's removed from package-lock too.
|
Weird, I remember removing it? Although, I was having some issues when I was switching branches with the differences with my package.json so I clean installed a couple of times on different branches , something may have gotten messed up. Will fix this shortly and repush @mattrunyon |
Resolves #1922
Changes Implemented:
Info on Nanoid: https://github.com/ai/nanoid/blob/main/README.md