Skip to content

fix: Replace shortid package with nanoid package #2025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AkshatJawne merged 11 commits into from
May 23, 2024
Merged

fix: Replace shortid package with nanoid package #2025

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
f589e97
Replace shortid with nanoid
AkshatJawne May 17, 2024
f822186
Make changes to fix e2e and unit tests failing
AkshatJawne May 17, 2024
8996bc7
Use generateId function in other spec files
AkshatJawne May 17, 2024
4db4d1f
Try different name for nanoid in preprocessors object
AkshatJawne May 17, 2024
9f038bb
Try string nanoid format
AkshatJawne May 17, 2024
64ae148
Add babelify as a dev dependency and transform
AkshatJawne May 21, 2024
7959a08
Fix sync of package.json and package-lock.json
AkshatJawne May 21, 2024
a4d668c
Add nanoid to dev dependencies
AkshatJawne May 21, 2024
c173f98
make nanoid a dependency
AkshatJawne May 21, 2024
d563da1
Fix merge conflicts
AkshatJawne May 23, 2024
0d849b1
remove shortid types from package.json
AkshatJawne May 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/golden-layout/karma.conf.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ module.exports = function (config) {
preprocessors: {
// '../src/**': 'coverage'
'./test/helper.js': ['browserify'],
nanoid: ['browserify'],
},

browserify: {
Expand Down
1 change: 1 addition & 0 deletions packages/golden-layout/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@
"babelify": "^10.0.0",
"browserify": "^17.0.0",
"karma-browserify": "^8.1.0",
"nanoid": "^5.0.7",
Comment thread
AkshatJawne marked this conversation as resolved.
Outdated
"watchify": "^4.0.0"
}
}
⚡